search

Razviar / marvelsnaptracker

Marvel Snap Tracker repo
https://marvelsnap.pro/
154 stars 34 forks source link

Mac OS Release? #30

Open konjelly opened 1 year ago

konjelly commented 1 year ago

I've been pulling my hair out trying to get this compiled on my Mac. I've never worked with Electron before, but I keep getting errors on things like "copy-webpack-plugin" or ".webpack/main" not existing. Rather than trying to fix my issues since I'm sure they're due to my inexperience, would it be possible for the next release to include a build for Mac OS, even if it is not officially supported?

Razviar commented 1 year ago

Like I said in #24 we don't have mac supporter/maintainer in our team. Basically I don't even have a mac computer to dev something for mac. If there's anyone how wants to step in and add mac support - it will be appreciated.

We have pull request #26 but I even have no idea how to test it lol/

konjelly commented 1 year ago

I appreciate the reply, and maybe I'm way off base here, but since it's an Electron app don't you just need to include the Mac as a target when you build? I.e. if you're using electron-builder, you'd just need to run something like this: electron-builder -mw (for Mac and Windows). That's what I meant by including one but not supporting it.

Razviar commented 1 year ago

That's the thing, to be able to build something I need at least a platform to run it on. With mac, you can't build mac Electron version on windows, you need to run mac build electron-forge scripts specifically under macOS. And it also needs a bunch of additional settings and you must know what you're doing. We had this tracker https://github.com/Razviar/mtgap working for mac (when we had mac supporter on the team), so you could take a look and check out how it was tuned in order to get it working.

borghe1 commented 1 year ago

starting to take a look at migrating this for M1/M2 Macs running the iPad app (kudos to SD for making the iPad app apple-sil compatible). Location of the live match files are ~/Library/Containers/SNAP/Data/Documents/Standalone/States/nvprod

borghe1 commented 1 year ago

ok, I have the tracker working on macOS. Overlay doesn't seem to be working (but I've never actually used it before). But tracking and syncing to msp is working. after installing npm and electron I just run rpm start run from the root of the directory. working on overlay now.

konjelly commented 1 year ago

@borghe1 you are amazing! If you need any help testing let me know.

borghe1 commented 1 year ago

currently it won't open the overlay window. I'm assuming it's looking for SNAP window.. and (I believe) to do so on macOS you need to give Accessibility permissions to the app for screen reader. I see what looks like some work started (included npm-mac-permissions in types) but I haven't figured out how to launch a prompt to give screen reader permission and can't manually assign it given a node.js project.. alternatively on Mac could simply force open the overlay bypassing the state of the SNAP window, at least to start.

borghe1 commented 1 year ago

Ok tracker is working perfectly with the site. Overlay is tricky. I have the window finally showing WITHOUT forcing it, but it’s not being updated and won’t reposition with the window. Working on updating next.

IngSubstance commented 1 year ago

@borghe1 there is a way to get your work and test it locally?

alessandrapereyra commented 1 year ago

@borghe1 Any way of getting access to your branch or changes? I would love to test them or maybe help with it.

ulasakdgn commented 1 year ago

Waiting for this excitedly. Thank you very much @borghe1 for your efforts.

androiski commented 11 months ago

Ok tracker is working perfectly with the site. Overlay is tricky. I have the window finally showing WITHOUT forcing it, but it’s not being updated and won’t reposition with the window. Working on updating next.

@borghe1 Need any help on this? I'm new to electron, but I have a Macbook with an ARM cpu