Razviar / marvelsnaptracker

Marvel Snap Tracker repo
https://marvelsnap.pro/
154 stars 34 forks source link

Bugs/inconsistencies and feedback in the Matches page #55

Open rampeara opened 9 months ago

rampeara commented 9 months ago

Hi! I switched from uncapped tracker to this one and liking it so far. I have found a few bugs/inconsistencies and feedback in the Matches page shown below.

  1. In conquest the matches shown are not in chronological order. From the image below my last match against "lightbringer" was the 5th one from the top. I expected it to be either first or last one shown vs that person.
  2. Although every row has a clickable "Replay" button on the right, only the last match vs a person seems to be recorded. In my image the last match can be identified with the card back next to the player name. When I click them I have full data on turn by turn and for the rest I only see the match details, the rest is empty. Could the contest matches vs the same person be overriding each other?
  3. Each conquest match vs a person shows same amount of time taken across the matches, which is wrong. Perhaps due to same issue as above.
  4. Each match row shows a clickable hand as cursor with everything inside the row when only the deck name and replay button are actually clickable. That confused me at first into clicking everywhere to see if I was getting some specific data or not.
  5. When the matches page is loaded it by default tries to load all matches, however the UI shows filtering by current date which feels inconsistent. I assumed it was me that didn't observe that the date dropdown would have been purple if it was currently selected, but when I changed the date it didn't turn purple. Perhaps the date dropdown should be shown as empty by default.
  6. There seems to be a bug with the from and to date filtering. In the image when I filtered only to Sep 14 I see all results up to that date, which is correct. However, when I filter Sep 14 to Sep 14, I get no results. I had to filter Sep 13 to Sep 14 to get results for Sep 13 only and Sep 14 to ahead Sep 15 to get Sep 14 results only. Perhaps an issue with using 00:00:00 instead of 12:59:59 in the time hash?
  7. Lastly I wished the cards in the tracker overlay showed the card details when you hover over them as sometimes I forget what a specific card does in either mine or enemy's anticipated deck but I can't check it via the overlay.
  8. Edit: Can you please add a shortcut for "Enable overlay" option? Currently when I try to hide my deck to better click on something there is still the "Current session stats" that show up. A shortcut would be helpful for totally hiding the overlay instead of having to go to the app and toggle it there. Edit 2: I see there seems to be a shortcut for the above here: https://github.com/Razviar/marvelsnaptracker/blob/master/src/app/hotkeys.ts#L17C7-L17C25, but Alt+` doesn't do anything for me, could it be a bug?

2023-09-14 16 24 00 marvelsnap pro 6c2c36497963