search

Razviar / mtgap

Support tool for MTG Arena online game
https://mtgarena.pro/
219 stars 50 forks source link

Completed matches are no longer recognized, probably because of the log file change #403

Closed bobanm closed 1 month ago

bobanm commented 2 months ago

Detailed context

Your Desktop:

Describe the bug

Since the latest update from 7 May, the completed matches are no longer recognized by the app. I noticed that Arena once again populates the log file with usernames in short format, without numbers. E.g. instead of username#12345 for most of the entries it only shows username. This happened already when update of 26 March introduced the same log file change, but Arena reverted that change in a later update.

I don't know if Wizards want to populate the log file with short or long username format. Rumors are they want to switch to short format, to prevent users from sending friend requests after completing a match, by reading the full username from the log. For MTGA Pro, I think it would be the best and future-proof solution to modify the code to match its users based on a short username format. Untapped.gg still works correctly and I don't think they use long format of Arena usernames.

To Reproduce Steps to reproduce the behavior:

  1. Play a match in the Arena
  2. Verify that the log has been parsed
  3. Go to https://mtgarena.pro/matches/ or https://mtgarena.pro/u/
  4. The match is not registered

Except for missing matches, everything else seems to work OK. Collection is updating and Profile page shows new cards obtained.

Revilak commented 2 months ago

Hello, about this problem Razviar replied on Discord server that the issue might be harder to fix .

bobanm commented 1 month ago

Fixed in 2.2.31, with explanation that @Razviar provided in Discord:

It was a nasty one, the issue was inside injected part of the code, related to serialization error due to internal game changes. So wasn't even about log changes. Version 2.2.31 should be tracking matches as ususal