search

Razviar / mtgap

Support tool for MTG Arena online game
https://mtgarena.pro/
224 stars 50 forks source link

Match history partially not tracked #86

Open vault101 opened 4 years ago

vault101 commented 4 years ago

Your Desktop (please complete the following information):

Describe the bug Account: vault103 Play matches recently with tracker opened, detailed log enabled. There was a progress on Feb.25, but matches in recent days were not synced.

To Reproduce Steps to reproduce the behavior:

  1. Play matches in Traditional Standard Ranked
  2. Check https://mtgarena.pro/matches/, latest match is on Jan.24; Check https://mtgarena.pro/u/vault103, there is only a progress on Feb.25

Screenshots

output_log.zip

Razviar commented 4 years ago

This is not global bug, I can see matches if you type being tracked right now. Can you please try to wipe settings in tracker and check if matches will start tracking?

vault101 commented 4 years ago

This is not global bug, I can see matches if you type being tracked right now. Can you please try to wipe settings in tracker and check if matches will start tracking?

After wiping I played one or two matches, and check mtga.cc/matches/?vault103, a match before I submitted this issue appeared, but latest matches not. Progress on profile page still shows Feb.25 though.

Razviar commented 4 years ago

Are you using any other trackers?

vault101 commented 4 years ago

Are you using any other trackers?

Only now I noticed I had untapped companion opened. I'll close it and try more.

MAC-GH commented 4 years ago

Hello,

In my case, I observed that the match tracking bug occurs only if the tracker and the MTGA are open and I pass the midnight i.e. the day changes. Also all progress (boosters opened and daily win cards) are not recorded if they happened before the midnight. If I quit the tracker and the MTGA before the midnight everything is updated fine. I'm using the latest version of the tracker.

Also, if the connection to the server is lost, so is everything that happened before the connection drop.

Comment update: more precisely, match tracking is not shown on My Arena / Profile page if the day changes or the connection is lost (this happens quite often during Brawl matches) but is shown in My Arena / Matches.

Cheers

MAC-GH commented 4 years ago

Hello,

Actually, not recording the matches result happens more often than I've thought even with the last version (2.0.38). I'm not sure whether the problem is the web site not showing the matches or a parsing problem (manually asking the log parse seems to do nothing) or something else.

Please find the attached log here UTC_Log - 03-31-2020 20.22.37.zip

A couple of matches do not appear in my matches history, specifically the one against ThorGodofThunder#23817. My connected account is Allirog#15154.

Cheers

Razviar commented 4 years ago

@MAC-GH I can confirm that match 1030f428-49f7-4a82-81fb-44fd8e8b967d Allirog#15154 vs ThorGodofThunder#23817 is present on log and completely missing in the DB. It has no trace at all. We still can't replicate this bug and find what is causing it.

MAC-GH commented 4 years ago

Hello,

Thank you for your reply. I tried a couple of times to 'Pick logs to parse' on the log file I've sent you and that changed nothing. Maybe that could be the start of the bug tracking. In case this could help, please find here another log file where my match against Maizena#28402 is also missing from the DB. A couple of weeks ago I also played against this same Maizena and that result is also missing from the DB. I'm almost inclined to think that the DB does not like some user names :-)

I try to give informations as relevant as possible to help find issues faster and please let me know if I could help any further.

Thank you for this great tool I use every day !

Jon UTC_Log - 03-31-2020 20.22.37.zip

Razviar commented 4 years ago

A little update on this. Since it's almost impossible to dig through log manually and find what's wrong, we started implementation of new tool which will allow us to check how tracked gets events from log and analyze what could go wrong. It will be comprehensive solution for issues like this, but it will take time. ETA is end of April. Then we will see why matches are getting lost sometimes.

florianlauer commented 4 years ago

If it can help, what I noticed is that the issue does appear when my decklist is wrong on the left side of the screen (for example, card picked during the draft but not selected in my deck)

Razviar commented 4 years ago

@MAC-GH so I have some news. We managed to make debugging rig for logs x-ray analysis and found, that this match in question 43282a97-30f5-4369-af8e-405acf7d190f against Maizena#28402 didn't had information about match ending in the log. For some reason game omitted the fact of match ending. Maybe it was connection glitch or something else.

So currently we see following pattern:

  1. Incomplete match record without ending mark gets into DB (after enforcing upload of this log I was able to see it)
  2. 24h later our garbage collection bot removes it from DB because considers it's broken (which is actually true)
  3. Then match is gone completely and we have no trace of it.

So currently I'm going to flag this as "MTGA log issue" but we'll keep monitoring. Maybe there's something more.

In addition to that, we will try to figure some solution for manual matches closure. For instance, if some non-match data starts to flood in (like collection or quest updates) we will automatically mark as ended latest match of current user.

MAC-GH commented 4 years ago

In the case the info about match ending is missing could it be stored into the DB as a draw and thus allowing us the consult the opponent's seen cards ? That could be a first step for the manual matches closure you've mentioned.

I also had some wins when the opponent retired from the game before even being asked to keep cards / mulligan. I wonder if that case is handled.

Cheers

ineffablebob commented 4 years ago

I suspect my issue is related to this one: I'm missing match results from my limited events. (I don't really track constructed, so not sure if those are missing too.) Using this account: mtga.cc/u/noteffablebob If I go to events and filter "Ranked Draft Theros Beyond Death (Mar 2020)" it shows two runs, each 3-3. So if I go to matches and filter "Ranked Draft Theros Beyond Death (Mar 2020)", I'd expect to see 6-6. But instead I see 0-3. Somehow only 25% of the matches got recorded.

Edit: Actually this is likely a separate issue, so I added issue 101. The reason I think it's different is that the matches are actually in your database - proven by them showing up when searching by event - so the problem I have isn't that the history isn't tracked. The problem is that the matches display page isn't showing what's actually in the database when searching by date (or any criteria other than event ID).

Razviar commented 4 years ago

thanks to @ineffablebob bunch of missing matches is found now.

RockFlagEagle commented 4 years ago

Hello I have a ton of matches missing as well. It seems to have started around the time that I began playing Historic, about 2 weeks ago. Only some intermittent matches are recorded, but most are not. Last recorded game is May 28th, but I've played a lot since then. No other trackers in use (didn't know about any others actually) Can't seem to pinpoint the issue. Attached is my log as of this morning... output_log.txt p.s. been loving this app, thanks for making it.