search

Razzmatazzz / RemnantSaveGuardian

Tool to backup your saves and view your world rolls
GNU General Public License v3.0
290 stars 41 forks source link

DLC: The Forgotten Kingdom #236

Closed TheNasbit closed 1 month ago

TheNasbit commented 2 months ago

General

TheNasbit commented 2 months ago

Still work in progress

MikeFindlay commented 2 months ago

Still work in progress

I have a bunch of the items you're looking for in the new DLC, but I'm not sure how to convert my save file into a readable format with the full item file path.

TheNasbit commented 2 months ago

Still work in progress

I have a bunch of the items you're looking for in the new DLC, but I'm not sure how to convert my save file into a readable format with the full item file path.

You can send the .sav file itself if you want. I have also a lot items - just had not the time to work on it before the weekend - so just started today.

MikeFindlay commented 2 months ago

save_0.zip Here it is. If its a quick explanation and you wouldn't mind sending a quick how-to, I'd enjoy learning. no problem either way tho.

Keller0Junge commented 2 months ago

bakup.zip this is my latest backup with SaveGuardian, it should contain all new items. Hope it helps :) *didn't know which of the 2 characters is the right one, so thats why you will find both in the zip file

identity7 commented 2 months ago

i dont have much, but i might have smth unique rem.zip

bakup.zip this is my latest backup with SaveGuardian, it should contain all new items. Hope it helps :) *didn't know which of the 2 characters is the right one, so thats why you will find both in the zip file

your profile.sav contains all character information(obtained guns/melee/armor/rings/amulets/etc...) for all your save slots. your save_#.sav contains world information(your rolled campaign/adventure/quest items) for each individiual save slot. save_0.sav is for slot 1, save_1.sav is for slot 2, etc...

ethaldeman commented 2 months ago

In your initial list, it seems you are missing the new relics, Profane Heart and Bloodless Heart

Frutaa commented 2 months ago

Should I upload a profile.sav that has collected all the new items, or some world save such as save_0.sav that collect each new item ?

Still work in progress

I have a bunch of the items you're looking for in the new DLC, but I'm not sure how to convert my save file into a readable format with the full item file path.

You can send the .sav file itself if you want. I have also a lot items - just had not the time to work on it before the weekend - so just started today.

identity7 commented 2 months ago

also, if anyone needs it for any reason, i have a save_#.sav with the unrolled DLC oneshot available oneshot.zip

Wuxriff commented 1 month ago

/Game/World_DLC2/Items/Archetypes/Invoker/Engram/Engram_Invoker.Engram_Invoker_C The last one?

ethaldeman commented 1 month ago

According to Fextralife wiki, Survivor Mask is currently unaviable to obtain in game. The remnant.wiki doesn't have a page for it.

TheNasbit commented 1 month ago

Big thanks to @Keller0Junge for the character file, and @identity7 for the savegame, both had a lot of items my file was missing, and saved lot of time :) And also to @MikeFindlay, even though I used mostly my own and the savegames of the other two, I still also thank you for your savegame :)

TheNasbit commented 1 month ago

If someone wanna test early, there is a pre-release over in my fork.

grunt000 commented 1 month ago

Dark Sea Armada Crest is incorrectly reported as missing.

identity7 commented 1 month ago

zero divide(n'erud random drop) as well

TheNasbit commented 1 month ago

Both Items should be fixed - (not updated pre-release (yet), but in this PR it's fixed now) - thanks. Let me know if you find more issues.

drkrthnblck commented 1 month ago

Both Items should be fixed - (not updated pre-release (yet), but in this PR it's fixed now) - thanks. Let me know if you find more issues.

How compatible is your PR build with the existing one—does it take existing settings into account, is there a way to safely merge the backed up saves, that kind of thing?

identity7 commented 1 month ago

Both Items should be fixed - (not updated pre-release (yet), but in this PR it's fixed now) - thanks. Let me know if you find more issues.

How compatible is your PR build with the existing one—does it take existing settings into account, is there a way to safely merge the backed up saves, that kind of thing?

perfectly. old version can be deleted and nothing is changed/lost since RSG doesn't directly manipulate the save files you might need to change some settings in rsg, like directory locations or other settings, but i didn't need to do this(i deleted the old folder outright)

TheNasbit commented 1 month ago

Pushed a Pre-Release with the fixes. -

KitakamiRei commented 1 month ago

Did a DLC2 adventure run through Yaseha. The Archer's Crest injectable was erronously reported to be in The Twisted Chantry but was actually instead in The Proving Grounds.

ethaldeman commented 1 month ago

When loading my save, I am getting the below error.

image

My Save is attached. 638502770659645341.zip

TheNasbit commented 1 month ago

When loading my save, I am getting the below error.

[...]

My Save is attached. 638502770659645341.zip

That's super odd, you get a Yaesha Injectable on a N'Erud Adventure in your save game? - Have to dig deeper. Something seems off.

Did a DLC2 adventure run through Yaseha. The Archer's Crest injectable was erronously reported to be in The Twisted Chantry but was actually instead in The Proving Grounds.

The tool sets the location for injectables to the "parent" location before the injectable - but seems like this is not always the case. Not sure yet how to fix it. It is not an explicit DLC2 problem, can also happen with DLC1 Stuff. Had it in the past some times. But I see if I can fix it. Can not promise it will fixed in this PR, tho.

VioletCapybara commented 1 month ago

I'm seeing an injectable (Flute Tower) that does not exist (I don't even have a possible spawning point for it) in a TFK adventure. It does not appear when using the current version of the program.

RSG_dlc2_err

Save is attached

m1ndgap commented 1 month ago

Using the PR 1.3.0.0 version I can see my backups from the 1.2.2.0 version, but trying to load them (world only) does nothing: new backup is not created and upon starting the game I just load where I left the game before. Is this intended?

Update: attached the log file, it says "04.05.2024 17:31:28: Backup restored" but that it was not. Error message before might be the reason. My friend got it running no problem, I'm not sure what's happening here. log.txt

xarcoft commented 1 month ago

Tested my save files with PR 1.3.0.0 and loaded successfully but is showing wrong location for some injectables and items. From my testing couldn't find Magnifying Glass anywhere on Malefic Palace, also Rookery injectable doesn't seem to be right to that location. image

Also rolled an adventure mode to get 3 items i was missing (Closed Loop, Zero Divide and Ring of Ordnance) but for 2 of them the location was wrong. image I actually found Closed Loop on The Hatchery and Zero Divide on Timeless Horizon. The location for Ring of Ordnance was correct.

Save file is attached

razeedazee commented 1 month ago

Not N'Erud

image

razeedazee commented 1 month ago

image

razeedazee commented 1 month ago

So i am rerolling the campaign to do something and i see these

image

razeedazee commented 1 month ago

I think i understand it, it's whatever the first world is.

image

Razzmatazzz commented 1 month ago

@xarcoft @razeedazee are these problems specific to this new branch and not preset on the current main release?

TheNasbit commented 1 month ago

@xarcoft @razeedazee are these problems specific to this new branch and not preset on the current main release?

These problems also appeared after DLC1, but it increased by a lot with the new content. It's mainly because of the parsing of the events, as the "world" is World_DLC1 / World_DLC2, and right now we take the "parent" event (previous events) / location's world.

It worked fine in most cases. Even though problems like those described above already happened sometimes before. The new DLC drastically increased the chance of it.

I think we have to change a bit of the parsing to fix it. Just replacing World_DLC1 with World_Fae, and World_DLC2 with World_Jungle won't fix it, that is what we had at the beginning of DLC1 adaption, but random drops on other worlds would then be listed as the wrong planet.

Razzmatazzz commented 1 month ago

Is this PR ready to go, or does it need some additional tweaking before being merged?

TheNasbit commented 1 month ago

Is this PR ready to go, or does it need some additional tweaking before being merged?

Problems are not because of the added items - IMO an rewrite of the Event parsing exceeds the scope of this PR. I AM working on the problem, but it is more an fundamental problem than problem bound to DLC2.

So yes - it is ready to go. BUT we have to work on the problems in another PR. The problems happened before - I got them myself in the past before DLC2. So its not "new" with this PR. With the new DLC you will see the problem more often.

Please do not think I will ignore the problems - I will work on it. But will take some more time.

razeedazee commented 1 month ago

bit late but i'll add it, the stuff i encountered was more a cosmetic issue, the functionality was fine for my particular needs, even this https://github.com/Razzmatazzz/RemnantSaveGuardian/pull/236#issuecomment-2091935631

It was mostly working maybe a couple of kinks to iron out.

TheNasbit commented 1 month ago

bit late but i'll add it, the stuff i encountered was more a cosmetic issue, the functionality was fine for my particular needs, even this #236 (comment)

It was mostly working maybe a couple of kinks to iron out.

@razeedazee It is the same issue that we have for a while now, it just happens more often with even more DLC-Contents: https://github.com/Razzmatazzz/RemnantSaveGuardian/pull/209#issuecomment-1827127426

We need to do some changes to the Event-parsing to fix them