search

Razzmatazzz / ValheimSaveShield

Automatically back up your Valheim character and world saves
GNU General Public License v2.0
68 stars 8 forks source link

Automatic save backups are screwed a bit by the latest patch (209.9) #39

Open BishopIngold opened 2 years ago

BishopIngold commented 2 years ago

With the way the new patch changed the general folder settings for Valheim, and Valheim dedicated servers, Save Shield is no longer correctly recognizing the directory structure.

Razzmatazzz commented 2 years ago

Oof, yeah that patch will require some adjustments for sure. Now that Valheim uses Steam's cloud save feature, is this app still as needed?

BishopIngold commented 2 years ago

I would say yes, as the cloud save overwrites each time, instead of saving the incremental backups.

pitsch commented 2 years ago

the incremental backup and selective restore became indispensable for a relaxed playstyle, makes little sense to go back to the game without it, celebrating mid summer night with gravestones and deskilling.

Razzmatazzz commented 2 years ago

I don't currently have the game installed and have limited capacity to work on this right now, so I'm not sure when I'll be able to get to it. But I'm happy to merge a PR from someone that fixes the issue and then release a new version.

sn0rkle commented 2 years ago

Hi @Razzmatazzz,

I have been looking into this and the only change is that the world and character folders now have "_local" appended to the end of them, so we need to look in "characters_local" and "worlds_local".

Ive been through and added _local to the literal strings which were folder paths and not the "type", i also appended it where Type was being used to derive the path. I must have missed something though as its still throwing an expectation somewhere around checking for a backup.

I am going to try and figure it out, but given you know the code and its just a folder name change, i thought i would let you know.

M

sn0rkle commented 2 years ago

Its having an issue as the backup folder with the name of the character/world is not being created, no idea why.

sn0rkle commented 2 years ago

I think i have submitted a couple of pull requests to fix the issue, i am a total git n00b, so fingers crossed!

sn0rkle commented 2 years ago

Also release here for the impatient: https://github.com/sn0rkle/ValheimSaveShield

MonolithTMA commented 2 years ago

@sn0rkle It works perfectly, thank you!

Razzmatazzz commented 2 years ago

Whoops, I thought that fix was included in the last release, but I guess not. Just pushed a new version that includes it this time.