Closed cforgaci closed 1 year ago
Having familiarised ourselves with each other's lessons beforehand, on the 3rd of October, we can focus on:
Let's carry out the tests until 1st of November.
@alwil Aleks, I just finished reviewing your lessons for Session 1. Here are a few thoughts:
@ClementineCttn @cforgaci I'm running into a host of errors trying to install the package sf on my Mac. It seems like it's necessary to install gdal via homebrew first, and then make sure sf is linked to the correct version (see here: https://github.com/r-spatial/sf/blob/main/README.md). Do you plan to cover these installation steps for Mac users prior to the workshop? I'm still working on troubleshooting.....any advice is welcome lol
@aecryan Thanks for testing!
@ClementineCttn I just finished going through your lessons for Session 4, and here are a few comments (I am on a Mac, btw, so potentially some of these geospatial packages/bindings are weird for me :) ):
looks great!
@aecryan thanks for reviewing Session 4. I will have to cover most of your comments in the previous parts as we start working with sf
in Session 2. Also, it is important that we send out detailed instructions about installation and data download.
@aecryan Hi Ashley Thanks a lot for reviewing lesson 4. It does take some time. I hope it won't be too much and I plan on explaining some things while it runs... as for 4c, I agree. Although the data won't stay the same. It is dependent on what @cforgaci uses in lesson 2 so I will update the lesson in time...
Tested lesson 1, looks good @alwil! Testing lesson 4 today + tomorrow. Sorry for the delay.
@ClementineCttn, I reviewed lesson 4. Looks great and well balanced in time as well.
I updated lesson 4c with the data I selected. I created a PR with the proposed changes, with some comments there, so it should not be much work for you. Please check that it also works on your end.
There is some repetition with the material I show in lesson 3, but I will remove those parts from there, which is great because my part was already a bit too long.
Thanks!