Rblp / Rblpapi

R package interfacing the Bloomberg API from https://www.bloomberglabs.com/api/
Other
166 stars 75 forks source link

Integration of condition code support into getTicks #147

Open joel23888 opened 8 years ago

joel23888 commented 8 years ago

Here are my initial thoughts on integrating condition code support into getTicks. @eddelbuettel or anyone else interested in this, could you let me know your thoughts?

I think it would be useful to have options to:

In terms of parameters and behavior:

eddelbuettel commented 8 years ago

I would like to keep the interface as unchanged as possible.

And I think we can do that if we simply ... give a different meaning to setCondCodes (maybe even call it getCondCodes ?): if it is set, return types requiring numbering representations (xts, fts, matrix) are all rules out. So condCodes implies data.frame.

As for the implementation, just make your core the default. For all other methods we convert the data.frame before returning and drop the condCodes column.

Easier?

joel23888 commented 8 years ago

This sounds good to me. I will take this approach. Will look at this next week (hopefully).

eddelbuettel commented 8 years ago

I am going to pick this up as just discussed in #146 which I suggest we revert.