release 0.3.9 (closes #290)

johnlaing commented 5 years ago

I'm a bit confused here. This commit is a direct child of at 0.3.8, and skips over everything else that was done in the last year.

Perhaps we are thinking differently about what constitutes a minimal maintenance release. If this commit is intended to constitute a standalone release (which I would be ok with), then I think it should not be merged into master.

eddelbuettel commented 5 years ago

Here is my reasoning:

1) It is a standalone release. See the branch -- it is

a one-line change to DESCRIPTION as discussed and requested by CRAN
an update to a now-dead URL in NEWS (harmless)
minor edits to NEWS as we had fscked up making the last release 0.3.7 AND 0.3.8 (harmless)
a one line addition to .Rbuildignore
NOTHING ELSE 2) That got rolled up into 0.3.9 and sits at CRAN. As minimal as we can make it, and we both agreed on that. 3) Also committed in a new branch I split off right at 0.3.8

All good so far?

Now, I fear the branch will one day get deleted and lost as a stale branch. So I figure given that we actually also need all the changes enumerated above in master itself we may as well merge.

But I am open. If you'd rather redo all those (minimal) changes by hand a second time in master you can. The changes have to go in, so we may as well preserve the commit and work record, no?

But as I said, open to other suggestions..

johnlaing commented 5 years ago

Fair enough

eddelbuettel commented 5 years ago

CRAN found a few more stale bloomberglabs URLs (in README.md and the vignette) so I scanned more carefully and updated all (ie in configure too).

eddelbuettel commented 5 years ago

Ok, and just wiggled the changes away from a merge conflict.

I suggest we squash merge this once we have green light from CRAN. (If we don't squash merge we probably get a pretty ugly long branch from 0.3.8 to HEAD.)

eddelbuettel commented 5 years ago

And green light from Uwe so merging now.

eddelbuettel commented 5 years ago

Package still in waiting at CRAN and I am getting a little irritated. I sent daily follow-ups.

Anyway, now added to the ghrr drat and announced on r-sig-finance with BCC to @alfredkanzler and @johnlaing .

eddelbuettel commented 5 years ago

Version 0.3.10 is now at CRAN.

http://dirk.eddelbuettel.com/cranberries/2019/04/07#Rblpapi_0.3.10

Rblp / Rblpapi

release 0.3.9 (closes #290) #291