Rblp / Rblpapi

R package interfacing the Bloomberg API from https://www.bloomberglabs.com/api/
Other
166 stars 75 forks source link

CRAN change request #328

Closed eddelbuettel closed 3 years ago

eddelbuettel commented 3 years ago

In email this morning to us and possibly over a hundred others (!!):

These have Markdown vignettes without at least suggesting one of markdown or rmarkdown, which currently "works" because markdown is a strong dependency of knitr. However, the knitr maintainer wants to change this so that knitr only suggests markdown in the future.

With the current CRAN version of knitr, building your package vignettes now fails with something like

The 'markdown' package should be declared as a dependency of the 'unrepx' package (e.g., in the 'Suggests' field of DESCRIPTION), because the latter contains vignette(s) built with the 'markdown' package. Please see https://github.com/yihui/knitr/issues/1864 for more information.

(for vignette engine knitr::knitr et al) or

The 'rmarkdown' package should be declared as a dependency of the 'validate' package (e.g., in the 'Suggests' field of DESCRIPTION), because the latter contains vignette(s) built with the 'rmarkdown' package. Please see https://github.com/yihui/knitr/issues/1864 for more information.

(for vignette engine knitr::rmarkdown).

See

https://github.com/yihui/knitr/issues/1864

for more information.

Can you please add the missing dependencies and submit a new version of your package to CRAN as quickly as possible?

Please fix before 2021-05-14 to safely retain your package on CRAN.

I think this only means adding rmarkdown to Suggests:. I will take care of it.

eddelbuettel commented 3 years ago

That appears to be the case. I just made the same change (with some other minor modernization that came up) in my RcppAPT package that was also affected.

eddelbuettel commented 3 years ago

And for completeness RcppAPT sailed through with the change and got pretest-publish (which we can't as this triggers the 'two-stage build turned off' note:

image

eddelbuettel commented 3 years ago

This was taken care of in d64319a1

eddelbuettel commented 3 years ago

Or as I just learned not quite :) The knitr package now enforces rmarkdown whether you use an rmarkdown vignette style or not.