search

Rblp / Rblpapi

R package interfacing the Bloomberg API from https://www.bloomberglabs.com/api/
Other
167 stars 75 forks source link

Fix BDS segfault #347

Closed klin333 closed 2 years ago

klin333 commented 2 years ago

Fix BDS crashes from #253

eddelbuettel commented 2 years ago

Thanks for reworking this. We work by an informal "majority of guilty parties onboard" rule so I will wait for either @johnlaing or @armstrtw to pipe in but this is otherwise fine by me.

armstrtw commented 2 years ago

I like the new patch. It's minimally invasive.

Please do keep the test code in your own branch. It will be useful to resurrect if any additional bugs surface later on.

eddelbuettel commented 2 years ago

@armstrtw Can you maybe hit the approve button for the code review? I just did the same, but it would be good if we had two (or more) "formal" hand shakes on this.