Closed johnlaing closed 2 years ago
We should certainly add a note about how to construct an FI search, perhaps with a reference to the relevant Bloomberg doc. Maybe we can change the example to something fake like "FI:YOURSRCH" and wrap it in donttest
. To me this is preferable to no examples and examples-relying-on-user-defined-options.
We should also note that COMDTY searches don't work due to missing parameters. If someone would like to step up and add that feature we'd be receptive to the PR. I don't use it so likely won't be doing that work myself.
As you now split the discussion between #355 and #356 here, feel free to also get back to me as to whether you consider this a release blocker or not. AFAICR bsrch
always was an add-on (by @wmorgan85) that was possibly less used so ... I'd be happy to just remove/comment-out the example and tests. I don't see this as a critical feature. Other takers?
As I see it, the most likely outcome is that we update the docs. That's low-hanging fruit and can easily be done prior to a new release. If anyone feels differently about what we ought to do about broken bsrch
that might change whether we hold a release for it.
Do you want to just push an update? (About to brace the cold here and go running....)
As noted by @mtkerbeR in #355
And with further digging also from Michael: After some research on this, it seems that there are two main domains used for function bsrch:
COMDTY: All examples I found in this category (i.e. bsrch("COMDTY:Weather") and bsrch("COMDTY:SHIP")) need additional parameters. According to Bloomberg Excel Example Sheet: "BSRCH allows you to download vessel data dynamically. Searches can be constructed by selecting parameters for the INPUT and OUTPUT preceded by COMDTY:SHIP". But additional parameters are currently not implemented for function Rblpapi::bsrch.
FI: According to Bloomberg Excel Help: "You can use BSRCH to import the results of a saved search from the Fixed Income Search (SRCH) function, so you can analyze the list of bonds or loans in Excel."
Hence a solution could be to have: