search

Rblp / Rblpapi

R package interfacing the Bloomberg API from https://www.bloomberglabs.com/api/
Other
167 stars 75 forks source link

minor typos #378

Closed micstr closed 1 year ago

micstr commented 1 year ago

Thanks Dirk for all the hard work you do on Stack Overflow and with this package.

I spotted some minor typos in the vignette which may help you.

All the best Michael micstr

eddelbuettel commented 1 year ago

Ok, I just rebased this off the main branch after merging @johnlaing 's pr first. Before I merge yours can you do us the honors and add a ChangeLog entry as we prefer to have a proper name and email for each contribution. Format is easy, you will see -- two spaces between iso date, name, email, tab to the entry. Thanks so much for considering this.

(And as I rebased you will want to refresh your branch relative to github.)

micstr commented 1 year ago

Thanks Dirk. I pulled the changes, added my changelog (with my details) and then pushed it up again.

Please let me know if you need anything else.

On Mon, Oct 24, 2022 at 3:07 PM Dirk Eddelbuettel @.***> wrote:

Ok, I just rebased this off the main branch after merging @johnlaing https://github.com/johnlaing 's pr first. Before I merge yours can you do us the honors and add a ChangeLog entry as we prefer to have a proper name and email for each contribution. Format is easy, you will see -- two spaces between iso date, name, email, tab to the entry. Thanks so much for considering this.

(And as I rebased you will want to refresh your branch relative to github.)

— Reply to this email directly, view it on GitHub https://github.com/Rblp/Rblpapi/pull/378#issuecomment-1289006827, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACKDRHT6P4W6RGLM6V7EEELWE2CYXANCNFSM6AAAAAARM266RU . You are receiving this because you authored the thread.Message ID: @.***>

-- Dr Michael Streatfield, CFA DPhil(Financial Economics), University of Oxford Tel: +27 82 904 2671 @.*** My research can be found here http://bit.ly/MPSpapers.

eddelbuettel commented 1 year ago

Perfect, thanks again. Now (squash-)merged to the main branch.