RbxStu / RbxStu-V2

The second generation of the Roblox Studio executor, RbxStu!
9 stars 3 forks source link

Submodules 'n Presets #18

Closed koxx12-dev closed 1 month ago

koxx12-dev commented 1 month ago

Moved every repo dependency besides luau to a submodule (tldr: repo in a repo) Added cmake presets for more consistent devex between editors Updated CI to use above mentioned presets

I would recommend soft forking luau at a later date and also making it a submodule

SecondNewtonLaw commented 1 month ago

This is not possible, some dependencies have been purposely modified from upstream, thus this cannot be done.

It would also increase the complexity more than it already is, not willing when this is not a looked at project

koxx12-dev commented 1 month ago

what dependencies? only luau seems to be modified

SecondNewtonLaw commented 1 month ago

what dependencies? only luau seems to be modified

some libraries have been modified to be statically linked

koxx12-dev commented 1 month ago

i have no idea what you are talking about, it works perfectly fine. im assuming settings triplets manually statically links every library needed

SecondNewtonLaw commented 1 month ago

i have no idea what you are talking about, it works perfectly fine. im assuming settings triplets manually statically links every library needed

Even if it did; I don't wish for the project to be splitted across many repositories, makes it more cumbersome to develop either way. I will only make a submodule architecture when I see it fit, and I don't see it fit currently, there is no reason to increase complexity that way, and libraries have been modified since I have used this old project template of mine before and I know that some dependencies are modified aside from Luau

koxx12-dev commented 1 month ago

ah, understandable i will make another commit with just presets

SecondNewtonLaw commented 1 month ago

ah, understandable i will make another commit with just presets

G then bro, ty for contributing, though