Remove uneccesary require('bunyan') call in rotatingfilestream.

Rcomian / bunyan-rotating-file-stream

Is an endpoint for bunyan that lets you control how much disk space logs take.

Other

29 stars 15 forks source link

Remove uneccesary require('bunyan') call in rotatingfilestream. #20

Closed connyay closed 3 years ago

connyay commented 6 years ago

This bunyan var is not used, and can cause problems if consuming library is using a scoped / renamed bunyan library.

connyay commented 6 years ago

Note - I don't have nvm on my box so I have not ran the specs yet. Will get them set up shortly.

Nodge commented 5 years ago

Any plans to release this?

Rcomian commented 3 years ago

Thank you very much for the contribution. I apologize deeply that it's taken so long to merge - this was to do with personal issues and nothing to do with you, your merge or users of this library. Hopefully I can get back to this.