Closed svennam92 closed 8 years ago
Am making progress on this issue. Officially supported node versions will be:
Other versions when requested.
0.10 was absent a lot of useful path manipulation logic which I'm not willing to patch in with packages. Unless explicitly requested I'm not going to support node 0.10 or earlier.
Other issues found:
setImmediate
may never fire.mkdir-recursive
does not work at all on 0.10, I've moved to mkdirp
even though 0.10 isn't supported for other reasons.I'm going to go with 1 compatible codebase at the moment. Some ES6 does provide nice syntactic sugar though (destructuring, non duplicate names in revealing modules pattern, arrow functions), so in the future may consider transpiling a compatible version for older node versions.
Functional test run times:
Perf test run times (1 million log writes):
I've release version 1.5.2 of the rotating file stream.
This release marks defined compatibility with a set of node versions with tests against each of those versions. Further issues with those versions should be raised separately, but this issue should be completed.
Short discussion here: https://gitter.im/Rcomian/bunyan-rotating-file-stream
SyntaxError: Use of const in strict mode. at /Users/svennam/git-apim/apiconnect-cli-logger/node_modules/bunyan-rotating-file-stream/lib/rotatingfilestream.js:23