Rcomian / bunyan-rotating-file-stream

Is an endpoint for bunyan that lets you control how much disk space logs take.
Other
29 stars 15 forks source link

Fix / Declare bunyan Peer Dependency #35

Closed thekevinbrown closed 1 year ago

thekevinbrown commented 1 year ago

Given that we depend on bunyan at runtime as a peer dependency it makes sense to declare this to package consumers. It needs to remain in as a dev dependency as well otherwise it won't be installed for devs, but this will declare the runtime dependency to package consumers without installing it for them.

Note: Contribution guidelines say I need to make check, but that currently does this for me:

❯ make check
make: *** No rule to make target `check'.  Stop.

But I believe I'm following the coding style. Definitely let me know if I need to do anything else here.