search

RcppCore / Rcpp

Seamless R and C++ Integration
https://www.rcpp.org
GNU General Public License v2.0
728 stars 209 forks source link

SET_TYPEOF #1312

Closed bbolker closed 1 month ago

bbolker commented 1 month ago

With the usual apologies if this is a red herring: the lme4 package is getting

Found non-API call to R: ‘SET_TYPEOF’. Compiled code should not call non-API entry points in R.

NOTEs with r-devel. My best guess is that these are coming upstream from Rcpp, e.g. see here; I don't find any instances of SET_TYPEOF in the lme4, Matrix, or RcppEigen code ...

eddelbuettel commented 1 month ago

We appear to have three uses of it:

edd@ahmad:~/git/rcpp(master)$ ag -c SET_TYPEOF
inst/include/Rcpp/Pairlist.h:1
inst/include/Rcpp/Language.h:1
inst/include/Rcpp/r_cast.h:1
edd@ahmad:~/git/rcpp(master)$

But I do not think I can offer you anything in the short term. Plead with CRAN that it is not you...

Enchufa2 commented 1 month ago

Yes, it's clear that we will have to address many of these, but of course it takes time. I don't think CRAN can expect to raise those NOTEs and WARNINGs and have them fixed overnight. I hope they can live with them for a few months in downstream packages to give us here time to adapt, address them one at a time and test properly.

bbolker commented 1 month ago

Thanks, I wasn't asking for them to be fixed in a hurry, just raising the issue.

Enchufa2 commented 1 month ago

Yes, I figured that much. :) Just stating the obvious so that you have a reference to plead with CRAN. ;-)