search

RcppCore / RcppEigen

Rcpp integration for the Eigen templated linear algebra library
Other
110 stars 40 forks source link

Do not throw INT_MAX error when returning vector #106

Closed jaganmn closed 2 years ago

jaganmn commented 2 years ago

Continuing from PR #105, fixing a bug introduced in https://github.com/RcppCore/RcppEigen/commit/f82ac81067c2ada51752f79b5c0fa8000396d0ad. wrap checked for dimensions exceeding INT_MAX even when the return value was a vector without dimensions. Unit test from other PR caught it.

jaganmn commented 2 years ago

Sorry to make you dig for my name, e-mail, etc. I didn't realize that my GitHub profile was empty... I'll update my answer on SO to say that the bug is patched now.

eddelbuettel commented 2 years ago

It's in git log though (and there is a great trick I learned from a colleague but for which I often forget about the details (so typing it out now may help me remember it another time ;-) ) where you just append .patch to URL of a PR. Also peels out the name and email as it turns the PR into an (old school, linux kernel too) emailable patch).