adapt preprocessor defines for result_of/invoke_result

RcppCore / RcppEigen

Rcpp integration for the Eigen templated linear algebra library

Other

110 stars 40 forks source link

adapt preprocessor defines for result_of/invoke_result #133

Closed tnagler closed 6 months ago

tnagler commented 7 months ago

Regarding #123: I don't really have the capacity to work on the Eigen 3.4.0 update, but I thought adapting the relevant parts (1, 2, 3) of the preprocessor logic could be an easy fix to make the warnings disappear (and ensure RcppEigen compiles with C++20)?

tnagler commented 7 months ago

Oh sorry, spotted some missing defines. Updating shortly.

eddelbuettel commented 6 months ago

Hi @tnagler we managed to get 3.4.0 in, at last! How do you about maybe rebasing and seeing if this would fit now?

tnagler commented 6 months ago

Oh that's great! After updating to Eigen 3.4.0, this PR should be redundant, because I simply stripped the relevant parts from the 3.4.0 Macros.h and Meta.h. I'll close for now and check these days, whether everything works.