search

RcppCore / RcppEigen

Rcpp integration for the Eigen templated linear algebra library
Other
110 stars 40 forks source link

vignette uses Rcpp:::bib() which now returns a null string #4

Closed dmbates closed 10 years ago

dmbates commented 10 years ago

Attempts to rebuild the vignette fail because the bib file is not defined.

romainfrancois commented 10 years ago

Perhaps we should give bib a less generic name and export it out of Rcpp.

dmbates commented 10 years ago

It's not the name, it's the value. In the past that returned the pathname of a .bib file in the Rcpp package installation directory.

eddelbuettel commented 10 years ago

I thought I had just fixed that for 0.10.6:

edd@don:~$ Rscript -e 'print(Rcpp:::bib())'
[1] "/usr/local/lib/R/site-library/Rcpp/doc/Rcpp"
edd@don:~$

but looking at the logs I see no change of mine.

Not sure we need it exported. So far this has passed all checks by the R CMD check police...

Also:

 edd@max:~/git/rcppeigen/vignettes$ R CMD Sweave RcppEigen-Introduction.Rnw 
 Writing to file RcppEigen-Introduction.tex
 Processing code chunks with options ...
 1 : keep.source term verbatim (RcppEigen-Introduction.Rnw:8)

You can now run (pdf)latex on ‘RcppEigen-Introduction.tex’
edd@max:~/git/rcppeigen/vignettes$ grep site-library RcppEigen-Introduction.tex 
\bibliography{/usr/local/lib/R/site-library/Rcpp/doc/Rcpp}
edd@max:~/git/rcppeigen/vignettes$

I thought for a moment that it might be related to other woes I had with vignettes recently but I don't think it is as we do not use a special driver for the RcppEigen vignette -- just plain old Sweave.

eddelbuettel commented 10 years ago

I think this can be closed. We had a few package uploads since this was opened, and all vignettes worked fine. It still uses the 'three-colon' form Rcpp:::bib(), and we seem to be allowed to do so because it is a package 'from the same family' which we import anyway.

If someone sees a need for an exported 'two-colon' version Rcpp::bib() please open a ticket over at Rcpp.