search

RcppCore / RcppEigen

Rcpp integration for the Eigen templated linear algebra library
Other
110 stars 40 forks source link

Update Frequency? #48

Closed cdeterman closed 6 years ago

cdeterman commented 6 years ago

I was wondering how often the 'newest' Eigen headers are ported in to this package? As what usually happens, I am dealing with GPU related problems and I noticed one pull request on the eigen bitbucket website that addressed the problem (quite minor in this case). I saw that it was merged back in May 2017 but the change isn't reflected in RcppEigen. Was a new 'official' release not provided by the Eigen authors perhaps?

I don't mean to push, as again this issue is quite minor in this instance. I am only curious how/when you decide to update the headers herein from the Eigen source.

eddelbuettel commented 6 years ago

Of late, this mostly relied on Yixuan really carefully preparing new releases and handing them to me more or less ready and on a silver platter. But he and I are busy so we let 3.3.4 slip.

The changes are small, generally, and go back to things @dmbates needed/added for lme4. If you start from backing out diffs from our 0.3.3.3.1 to their 3.3.3, you should be able to prepare a 0.3.3.4.0 for us :)

yixuan commented 6 years ago

Let me prepare an update this weekend.

yixuan commented 6 years ago

@cdeterman The patch you mentioned actually has not been ported to the 3.3 branch of Eigen. It was in the "default" branch, but I have manually patched it for you in #49 .

cdeterman commented 6 years ago

@yixuan excellent, thank you for your efforts.

eddelbuettel commented 6 years ago

And it is sitting in incoming at CRAN now.