search

RcppCore / RcppEigen

Rcpp integration for the Eigen templated linear algebra library
Other
110 stars 40 forks source link

SparseSelfAdjointView.h:... warning: .... [-Wtautological-compare] #88

Closed f-rousset closed 3 years ago

f-rousset commented 4 years ago

Hi, GCC 10.1.0 (Debian 10.1.0-1) emits a "significant" (according to CRAN check results) warning
RcppEigen/include/Eigen/src/SparseSelfAdjointView.h:456:14: warning: bitwise comparison always evaluates to false [-Wtautological-compare] and same issue at SparseSelfAdjointView.h:489:14

These warnings are reported in r-devel-linux-x86_64-debian-gcc checks for at least two packages here and there and I know no other configuration that reports it (meaning in particular that did not reproduce it myself).

Should I report this upstream ? The current SparseSelfAdjointView.h file is identical to the one included in RcppEigen as far as I can see.

Best,

F.

Edit: from the comments, the warnings are expected to disappear soon from the cran check pages.

eddelbuettel commented 4 years ago

Should I report this upstream ?

Yes please! Eigen development appears to be slower which is not uncommon for a mature project, but responsive. We have seen several bug fixes in recent years. If you hear something back can you let us know here too?

kevinushey commented 4 years ago

FWIW it looks like R-devel now omits these checks:

https://github.com/wch/r-source/commit/bd976c155b3868c4daaa3a3aec3bef04e611c861

(although I'm sure they'd be happy to see these warnings gone, nonetheless)

On Tue, May 26, 2020 at 12:59 PM Dirk Eddelbuettel notifications@github.com wrote:

Should I report this upstream ?

Yes please! Eigen development appears to be slower which is not uncommon for a mature project, but responsive. We have seen several bug fixes in recent years. If you hear something back can you let us know here too?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/RcppCore/RcppEigen/issues/88#issuecomment-634247306, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAPCSBTPEUODTRC6OZKISVLRTQNQLANCNFSM4NLASTOA .

eddelbuettel commented 4 years ago

Nice catch there!

f-rousset commented 4 years ago

Caught before hiding... and nevertheless now reported to Eigen.

eddelbuettel commented 3 years ago

I am closing this as it should be taken care of in Eigen 3.3.9 which just got to CRAN as RcppEigen 0.3.3.9.1. Let me know if you still have issues.