`CXX_STD = CXX11` causes CRAN note on devel

RcppCore / RcppParallel

High-level functions for parallel programming with Rcpp

http://rcppcore.github.io/RcppParallel/

171 stars 58 forks source link

`CXX_STD = CXX11` causes CRAN note on devel #196

Closed rorynolan closed 1 year ago

rorynolan commented 1 year ago

CXX_STD = CXX11 causes a CRAN note. The current CRAN default is C++17 and it doesn't like you to specify an older version. The easy fix is to change the docs 11 -> 17 but that too will probably be too old someday. Perhaps the docs could just say that at least C++11 is required for RcppParallel to work but not do anything in Makevars? Up to you how to tackle this, just wanted to make sure you were aware.

eddelbuettel commented 1 year ago

Duplicate of #194

kevinushey commented 1 year ago

I think there are some places we need to update:

The skeleton function, here: https://github.com/RcppCore/RcppParallel/blob/649340b18dbaf834859c07e8701f3ea7a0c650da/R/skeleton.R#L108-L130
The documentation for the GitHub pages site here: https://github.com/RcppCore/RcppParallel/blob/16876a23f98866b9985bc657c90c678d6c533314/index.Rmd#L80-L96

I'll fix those up.

eddelbuettel commented 1 year ago

One thing I have been wondering, though, is whether or not we should set a CXX_STD. "Way back when" we had to as the then-default compiler was insisting on C++98. Now we have modern C++ by default, and adding this feels like adding a constraint. Should we just leave it open? (IIRC) R 4.0.0 turned on C++11, R 4.1.0 turned to C++14, R 4.3.0 will turn on C++17. Good enough?

Edit: Doh. And I wrote that before I saw your commit. And you did the Right Thing (TM) :heart: