Incompatible with facebox v0.4

RdeLange / robinvision

Face recognition Service

MIT License

17 stars 6 forks source link

Incompatible with facebox v0.4 #2

Closed robmarkcole closed 5 years ago

robmarkcole commented 5 years ago

I'm afraid that compatibility with the HA facebox component is broken in https://github.com/robmarkcole/HASS-Machinebox-Facebox/releases/tag/v0.4 as the bounding_box and image id of a face are now explicitly parsed by parse_faces(). I see that face_recognition.face_locations does return bounding boxes so this could be implemented. id could be anything.

Note that a workaround is to comment out face[ATTR_BOUNDING_BOX] = entry['rect'] and face[ATTR_IMAGE_ID] = entry['id']

RdeLange commented 5 years ago

Thanks for pointing out. using the face_recognition.face_locations should do the trick indeed. When I have some time I will get that squeezed in.

RdeLange commented 5 years ago

Hi, now included the bounding box and included a dummy id to get it work. Hopefully this works now. I am currently having some problems to test is with HA myself

robmarkcole commented 5 years ago

Works, nice!