ReClassNET / ReClass.NET

More than a ReClass port to the .NET platform.
MIT License
1.81k stars 369 forks source link

Add setting for optional zip compression (different approach) #244

Open DisabledMallis opened 1 year ago

DisabledMallis commented 1 year ago

I know someone already opened a PR for this feature, however I decided to try implementing it a little differently on my fork. Instead of modifying the ReClassNetFile class(es), I decided to create a new one called ReClassDataFile. Enabling/Disabling the "Compress as ZIP" under a new "Project Settings" tab will enable/disable the use of ReClassDataFile over ReClassNetFile. The benefit of using a new class to implement the feature is that it continues to follow the current code format/style, whereas just modifying the ReClassNetFile class directly could encourage code to become a little 'messy'.

There are some more things I should probably fix/change to make this a better suited PR for merging, such as: