search

ReCoded-Org / lets-share-capstone-project

3 stars 2 forks source link

feat: single item page done #40

Closed aghimohamad closed 2 years ago

aghimohamad commented 2 years ago

single item page done (closes #33 )

Render

Desktop:

image

Note: i've prepared the file to work on dynamic routing so if you want to check it out just change its name from [item] 'index'.

aghimohamad commented 2 years ago

The styling is cool. I liked the slider. Maybe @hanimuh can have a quick review later after we merge.

I have a suggestion regarding the functionality. Would not be better to prepare a function that handles the dynamic routes, I am talking about "getStaticProps", and "getStaticPaths"

The styling is cool. I liked the slider. Maybe @hanimuh can have a quick review later after we merge.

I have a suggestion regarding the functionality. Would not be better to prepare a function that handles the dynamic routes, I am talking about "getStaticProps", and "getStaticPaths"

hey amjad yea i thought about that actually but since we don't have any where to fetch from so the functions would be empty which means eslent test won't bass, but thanks for the suggestion