search

ReCoded-Org / lets-share-capstone-project

3 stars 2 forks source link

feat: locale-en #47

Closed aghimohamad closed 2 years ago

aghimohamad commented 2 years ago

added locale file for English, added a custom 404 page;

Notes :

  1. please give it a deep review since all translation files will be dependent on this file, and tell me if i missed any page or key.
  2. I've removed any spaces from the keys so it can help with recalling it while translating.
  3. I would appreciate reviewing the custom 404 page I made if it needs any edits.

Related Issue

aghimohamad commented 2 years ago

Thank you for submitting your work @aghimohamad . Really appreciated. It was nice to add 404 page.

I have some suggestions, which you may want to put into consideration. I would like to refer to @tech-chieftain to discuss these suggestions.

  1. Changing the name of the file itself. "common.json" could be used if you want to keep only the common words inside it.
  2. there are some redundant words, such as login,logout,name email...etc. You can add them to the "common" section.
  3. If possible, you can add null objects for the blogs such as the following: "blogs" { blg1:{ header:"header1", content: "content1"}, blg2:{ header:"header2", content: "content2"}, blg3:{ header:"header3", content: "content3"}

}

  1. an extra great bonus could be add a translation for the 404 page. You can create an object under the name "errPage"

hey, @amjadmak really appreciate the review and the suggestions, will be working on it now. Regarding the blogs, we discussed that they won't be translated. and for the 404 page, we can do that later