search

ReDEnergy / SessionSync

SessionSync
Mozilla Public License 2.0
296 stars 31 forks source link

Firefox 86: scrolling in SessionSync popup is broken #103

Closed charlieok closed 1 year ago

charlieok commented 3 years ago

After updating to Firefox 86, I am unable to scroll using either a mouse wheel or touchpad in the SessionSync popup.

I see an issue was filed when Firefox 86 was in the Nightly channel:

https://github.com/ReDEnergy/SessionSync/issues/100

That issue was closed a few days later by the person who filed it, with a note that it might apply to extensions generally rather than SessionSync specifically. After testing that idea a bit I can say that scrolling works fine for me in some other similar extension popups, such as Multi-Account Containers and SEOInfo, and thus far I've only noticed a scrolling problem for SessionSync.

ReDEnergy commented 3 years ago

God... I really wish Firefox would not break so many things after each update :|. The problem is like this. That specific panel is actually built using 100% HTML/JavaScript/CSS code. There can't be a problem with how the panel is build suddenly. I have Firefox 87 and works as intended, and used it on Firefox 86 a lot without any issues. What exactly does not work in your situation really beats me. Is not like I've implemented any kind of special scrolling inside the panel... the scrolling is provided by the browser itself because the content is greater than the viewing area. Sadly, there's not really something that I can go and fix about this. I haven't implemented any scrolling so there's nothing to check/fix and I sincerely have no idea where to start looking for such a problem. I do understand it's happening only in the case of my addon but the reason is still somehow the browser itself, or something from the profile files.

Ideas to check:

Sorry for not having a solution but the bug is simply something like... The browser does not act as it's suppose to. It's impossible for me to check and find a solution for a feature offered by the browser itself.

image

charlieok commented 3 years ago

Ok. First off, thank you very much for making this extension. The fact that its backing store is the browser's bookmarks (which can be synced between installs on multiple machines) is a nice approach, and is one of the main reasons I decided to use the extension in the first place.

In my time using SessionSync I have gone from not really using the browser's bookmarks at all to amassing over 77000 bookmarks and counting. I realize I may be pushing the tool way past what you thought anyone would do, but that's a sign of just how useful it has become to me. That means many operations involve some delay now, but I was tolerating that because I have not figured out what a better setup would be or how I would migrate all that data once I found one. (I'm staring to think about the possibility of syncing between a SessionSync bookmark folder and a site like pinboard or instapaper or pocket. Don't know if those data models would map well bidirectionally or not).

With the scrolling issue, I am unable to find things unless I remember exactly what I'm looking for with enough specificity to narrow the displayed items to the point where no scrolling is necessary to see the item. So anything that would provide another way to scroll the view would make it at least usable again. For example, if up/down arrow keys could move the item selection up and down, maybe that would allow the view to move and things outside the current view would again be reachable.

Meanwhile, I will try your uninstall/reinstall suggestion and see if that make a difference, and report back.

charlieok commented 3 years ago

I've just uninstalled the extension, quit firefox, restarted firefox, and reinstalled the extension. Still no scrolling unfortunately :(

charlieok commented 3 years ago

ok after looking around a bit through the settings I see I can detach the popup into its own window. I was unfamiliar with this option. Maybe I missed it or maybe it wasn't there when I first set it up and was added in a later version. In any case, scrolling works in the detached window mode so my immediate usability problem is solved. It also solves some other problems I was having, like getting a bigger working area, and not incurring a delay each time I open the popup.

Thanks again for the great extension!

p.s. hmm, some things are going to take some figuring out with the detached-window way of working. For instance, the 'add current tab' button just adds a 'Session Sync' tab, because session sync is the focused window, so it's bookmarking itself. My instinct at this point is to drag a link from a browser window into the open session sync window, but that drag/drop action is apparently not supported. Actually it destroys the session sync detached window by replacing its contents with the page I tried to bookmark. So instead I have to remember to not attempt this drag and drop, and instead I have to open the popup again to bookmark a new page, even though I have the session sync detached window open. Hmmm.

bayeslearner commented 3 years ago

I can confirm I have the same issue. Detaching as a popup seems to get around it.

charlieok commented 3 years ago

I'm now running Firefox 88.0 (on Big Sur 11.2.3 in case that matters) and I noticed that I can scroll in the Session Sync toolbar popup again! That completely fixes this for me. Maybe Firefox made a change that fixed it? Not sure.

As far as I am concerned this issue can now be closed but rather than just click 'close' right now I'll leave it to the maintainer to decide how to handle it from here.