search

ReDEnergy / SessionSync

SessionSync
Mozilla Public License 2.0
296 stars 31 forks source link

Permanently save the last session before Firefox ends #52

Open adminarf opened 6 years ago

adminarf commented 6 years ago

The auto-restore session feature sometimes doesn't work, and sometimes multiple-immediate successive crashes loses the last good session. Also, sometimes it is helpful to use a session from many days earlier even though it was not previously saved.

One possible way to implement is to permanently save the last auto saved session whenever Firefox starts.

ReDEnergy commented 6 years ago

Thanks for submitting the issue. Yes I know the auto-restore session feature is not perfect. I've been working on something that should improve the overall experience but I was not really able to finish it (couldn't find the time required). I will try to hurry the change because I know that it's one place really problematic for the addon.

adminarf commented 6 years ago

Thanks for the reply Gabriel. I look forward to the updates.

---- On Tue, 09 Oct 2018 18:13:01 -0400 notifications@github.com wrote ----

Thanks for submitting the issue. Yes I know the auto-restore session feature is not perfect. I've been working on something that should improve the overall experience but I was not really able to finish it (couldn't find the time required). I will try to hurry the change because I know that it's one place really problematic for the addon.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

cgilleybsw commented 5 years ago

Has there been any work done to resolve this issue? I just lost two+ weeks of research (yeah, I know I need to be more careful). With Windows 10, we now have potentially 6 desktops. Toss in an occasional system crash, a rogue popup on another desktop, and a robust session manager for FF is priceless. Haven't found one yet for FF. There always seems to be some stupid logic behind when the current session is saved. Hint: it should be saved on a regular basis.

ReDEnergy commented 5 years ago

HI @cgilleybsw . I have most of the work done (in code) but I still miss some aspects on the UI so I was not able to release it yet. The implementation is sort of ready in a the beta release but that was meant for fixing another bug so I didn't finish this issue properly. I'll try to push it as fast as possible. Really sorry for the bad experience you had with those crashes. I will update this thread once the feature is ready and the update is launched. I would say that most probably it should fix most issues anyone had with the auto-saving functionality because:

Sadly can't really save complete browser history (history for each tab) but only a snapshot of what the browsing history looked like whenever the save is triggered (plus closed windows will not be deleted anymore)

ReDEnergy commented 5 years ago

Regarding the crash and losing the data, I'm not sure if what I will do will definitely fix everything since if Firefox itself may corrupt saving data it may be something I can't fix because it not my fault in the first time. All I can do it's to save the data into different storage areas and hope that even if the crash affects something it will affect only the last save.

Also please understand that I cannot permanently save history data into bookmarks... I do save everything permanently but only in addon localStorage and that one seems to be prone to some bugs (not mine). I cannot save everything automatically into bookmarks since bookmark saving can be really slow and will make the addon unusable for those that have a high number of tabs opened.

The addon was mainly built so that you can save whatever "session" into permanent bookmarks on demand. Those 2 weeks of research data are a really good fit for on-demand saving (whenever you remember) and you can even replace entire sessions whenever you want to overwrite them.

I do understand that auto-saving is critical for some users but trust me... I can only do that into LocalStorage and if Firefox decides to throw that data away after a crash (not sure why would that happen but having in mind that some users managed to lose everything I guess it's possible) I don't think I can do anything about it. Thanks for understanding.

cgilleybsw commented 5 years ago

Appreciate the feedback. I am completely ignorant about how FireFox add-ons and this environment operates, so it is what it is. 👍

ReDEnergy commented 5 years ago

@cgilleybsw I just sent a few more background information on the feedback mail I received. Like I explained there, things are not really easy and it's not every-time the developer at fault. The new Firefox Web API build after Chrome it simply idiotic, and restrictive. They say it's for security reasons but It's so limited that I prefer any other moment to have less security and more features at least when you know what you're doing with certain addon I don't see any problem. I really miss the API prior to Firefox 57...

cgilleybsw commented 5 years ago

Don't sweat it. Interesting you would comment about the restrictions. My preference for browsers is firefox - I just like it better than chrome - but the chrome extensions I can load don't seem to have this problem. Just to be clear - when my system goes down, many times it's an auto-reboot from Microsoft. I seem to have been able to slow that down, but I can lose VMs from time to time.

As for their "security" nonsense, FF seems to get hijacked by sleeper URLs far more often than chrome, so that's pretty funny.