search

ReDEnergy / SessionSync

SessionSync
Mozilla Public License 2.0
296 stars 31 forks source link

UI improvement for saving new sessions #59

Closed Clindbergh closed 5 years ago

Clindbergh commented 5 years ago

Thanks for this great addon and development!

When saving a new session explicitely (by clicking the heart icon) I would specifically name that session. This currently requires 5 Clicks:

  1. Session Sync Toolbar Icon

  2. Heart icon to save the session

  3. Right click on the newly added session to edit its name grafik

  4. Click Edit

  5. Highlight the current session name in the edit field with mouse click-dragging (or CTRL + A) grafik

  6. Save the session with a click on the save button (or ENTER)

It would be nice if the we could skip steps 3-5 (including). So the new flow would be:

  1. Click on Session Sync Toolbar Icon
  2. Heart Icon to save session
  3. The edit text field for changing is presented with current text highlighted. After typing text, click the save button (or ENTER) grafik
ReDEnergy commented 5 years ago

Hi. I don't get what's happening. What you described in second section is the actual behaviour that is suppose to be happening. Is it not working in your case ? I mean... right after you on the click the save icon.. the edit box with the session name should appear.

ReDEnergy commented 5 years ago

Oh... forgot. The thing is... if you have more than 1 windows saved, I can't show that box. The edit box will only be triggered if you save only one window, because otherwise I can't know for sure which one should be edited and even if I would select one of them it might be a little strange to only change one.

P.S you can also double-click on the session entry to rename it. No need to go through the context menu.

ReDEnergy commented 5 years ago

Oh... actually I think I found a bug. Thanks for reporting it. Seems that what you described only works if the Multi-Window toggle is on, and you have just one window active. image

This is a stupid bug, no idea how I missed it when testing. I will try to provide a bug-fix as soon as possible.

ReDEnergy commented 5 years ago

I fixed the issue. Also added auto-select. I will update the new version in a few days just so that I can test is a little bit to make sure I didn't brake anything (I fixed a few other issues as well so better safe than sorry)

If you want to test it you can download the signed addon from here. It's exactly as it's suppose to be delivered in a few days, but has 3 debug buttons in the addon menu.

Clindbergh commented 5 years ago

Thanks for the quick follow up! I wasn't aware of the Multi-Window toggle. I was expecting that all tabs of all windows were saved to one session.

The signed addon works great, for both cases (Multi-Window on and only one window and Multi-Window off). Thanks!

Clindbergh commented 5 years ago

Do you plan to push the code for the new signed addon to the repository? I noticed that the last commit was in July 2018.

ReDEnergy commented 5 years ago

Yes, I'll do that once I push the addon to oficial release. I kinda messed up my local repository because I had working on several complex features and I need to do some cleanup first to merge them properly. Probably I will do this today or tomorrow