search

ReDEnergy / SessionSync

SessionSync
Mozilla Public License 2.0
296 stars 31 forks source link

Display issue when pinned to the overflow menu in Firefox #61

Open sojefingcool opened 5 years ago

sojefingcool commented 5 years ago

The extension does not display properly if it is pinned to the overflow menu in Firefox

ReDEnergy commented 5 years ago

Sorry but I really can't do anything properly with that overflow menu width size... It's not my fault that Firefox impose this stupid limitations with width/height. If it's pinned to the overflow menu Firefox will force the menu width onto the addon. It's just impossible to do something within that area so basically my hands are tied.

sojefingcool commented 5 years ago

What about adding scrolling to your popup similar to how Tabby (https://addons.mozilla.org/en-US/firefox/addon/tabby-window-tab-manager/) handles this limitation?

ReDEnergy commented 5 years ago

Well... Of course. With enough effort a lot of limitations can be somehow overcome but it's not an easy task in this case. What I might be able to do is to make the whole UI mobile friendly, which means that the session list should be a hidden panel on the left side of the screen similar with how the options panel is implemented. By doing this, there should be just enough space to be able to display a full session in the main view and whenever you need to select another session, just by pressing a small button will slide the session lists from the left side.

So, yes. The short answer is, I might be able to do something about it. The reality is that's I'm not really sure how easy it is with the way the UI is built right now and of course as much as I would like to have this done as soon as possible there's also a huge list of missing features that is waiting to be implemented so I can only promise that I will seriously consider this feature but I can't promise when and if it will be available. As it might also help me push a mobile version of the addon I will probably try it sooner. Thanks for understanding.

sojefingcool commented 5 years ago

A simple interim solution could be to provide an option to allow the button click for the extension to open the tab view (my preference) or window view instead of the popup.

ReDEnergy commented 5 years ago

Sadly I don't think the API lets me do that. Not 100% sure about it (I'll look more into it) but from what I remember there's simply no way to know if the addon is pinned in the overflow menu or not. Since I can't know for sure that information it's impossible for me to anything. Not that the API would let me open the TabView when I would click on it but I let's say that I would hack the behaviour in a different way. Probably I can provide another button that does exactly this, opens the UI straight to the TabView, but then users will have to use Firefox customize to move that specific button there and hide the default one.

sojefingcool commented 5 years ago

Thank you for the response, but I'm not sure I follow why the API capability would be necessary to implement this functionality. I'm not suggesting that the extension need to intelligently detect if it's pinned to the overflow menu to determine how to respond to the extension button click. Instead, I'm suggesting that an option is simply added to the extension settings to allow the user to configure the behavior of the extension button click: (1) open extension popup (default), (2) open extension tab view, or (3) open extension window view.

ReDEnergy commented 5 years ago

:D that's why feedback is so important. I don't know why I haven't thought about that. I looked over the API and seems to support changing the behaviour from the code.. so I should be able to do that very easy. Assuming it's a 10 minutes change I will try to land this in the next update. Thanks for feedback.

sojefingcool commented 5 years ago

Awesome, thank you!