ReDEnergy / SessionSync

SessionSync
Mozilla Public License 2.0
296 stars 31 forks source link

Tabs dont resolve on Firefox start #67

Open Andrewsuares opened 5 years ago

Andrewsuares commented 5 years ago

Hello,

I'm on Firefox 66.0.2 on Windows 8.1. Tabs don't resolve on Firefox start for atleast 2 minutes. If I click on Session Sync the active session does'nt show anything. After about 2 minutes, tabs begin to load the sites and Session Sync shows the current session etc.

Is there a reason for the delay?

ReDEnergy commented 5 years ago

There's nothing related within the addon that can trigger this behaviour. Whenever the Active session is pressed the addon queries the WebExtensions API to receive the tab list. It should be right away. Now what, it's happening in your case is pretty strange, but sadly I don't think is something related to the addon itself, but most probably something related to some settings, maybe the Firefox profile is broken or the WebExtensions API hangs somehow for 2 minutes until data is ready. Sadly, I don't think I can do anything about this since I do snow them as soon as I get the tabs information from the WebExtensions API.

Andrewsuares commented 5 years ago

Ok thanks. Btw, does session Sync auto add and delete the bookmarks from the current session into the bookmarks? or do I manually need to do this?

ReDEnergy commented 5 years ago

No auto saved to bookmarks is done.. all entries in the Sessions tab are saved to boomarks (but those are added when you press the Save button). Since bookmarks usually represent valuable storage for each user I won't save automatically everything there and also it can have quite an impact on performance so that's another reason. image

The History tab keeps tracking of current and past sessions. That's automatically and whenever you want to "promote" a history session to a bookmarked session you can do that by pressing the save button.

image

Andrewsuares commented 5 years ago

I really like the Bookmarks feature. Can't imagine why other session managers wouldn't implement it. Makes it easy to access session tabs via bookmarks on other devices. Would be nice if you could make the save to bookmarks icon more obvious. Maybe use a star. The pop just says 'Save Session'. That could have been 'Save to Bookmarks'.

On Thu, Apr 11, 2019 at 6:43 PM Gabriel Ivanica notifications@github.com wrote:

No auto saved to bookmarks is done.. all entries in the Sessions tab are saved to boomarks (but those are added when you press the Save button). Since bookmarks usually represent valuable storage for each user I won't save automatically everything there and also it can have quite an impact on performance so that's another reason. [image: image] https://user-images.githubusercontent.com/1395510/55959832-3fed7880-5c74-11e9-9548-5c7f11810eaa.png

The History tab keeps tracking of current and past sessions. That's automatically and whenever you want to "promote" a history session to a bookmarked session you can do that by pressing the save button.

[image: image] https://user-images.githubusercontent.com/1395510/55960093-bf7b4780-5c74-11e9-82fb-61768ec3c382.png

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ReDEnergy/SessionSync/issues/67#issuecomment-482108620, or mute the thread https://github.com/notifications/unsubscribe-auth/AhveCZmtYjdf9ItN25nrvQEtz-j2egzNks5vfzUFgaJpZM4cmDb3 .

--

Best Regards, Andrew Suares

ReDEnergy commented 5 years ago

That makes sense... but at the same time I wonder if It can confuse people why "Save to Bookmarks" is something that is shown inside the addon interface and you can't save somewhere specific into bookmark. Basically I thought that the description of the addon should cover the actual behaviour and everyone would understand what that save means, but I get that it can be confusing. Yeah... one thing is clear. There's more I can do regarding explanations, tooltips and even improve the tutorial (if people do actually look over it, it should explain a lot) but it's hard to decide what exactly covers everyone understanding of specific feature properly.

Andrewsuares commented 5 years ago

Based on my experience, I was searching for a Session Backup tool in the add-ons area. I did a search for 'session' to see what would appear. Somewhere in your description, I read about 'bookmarks' and installed thinking it may auto backup to bookmarks.

I would suggest to make the UI easier to understand on how to backup to bookmarks. The sessions saved area is easy to see and understand. Tutorials, no one looks.

1) Make the add to bookmark icons better, following Firefox's icons used for Bookmarks 2) On save, Show that the session has been added to Bookmarks. I had to go to bookmarks to see if the session was added and where it was added. Needs some notification on save. 3) Maybe an auto backup to bookmarks once a day? 4) Use "Backup Session to Bookmarks" instead of "Save to Bookmarks". 5) The sesson sync icon and the sessions tab feels the same. It is not clear that the session sync icon is the one where you have to click on the heart icon to save to bookmarks. I would say this is the core area of the add-on.

On Thu, Apr 11, 2019 at 6:57 PM Gabriel Ivanica notifications@github.com wrote:

That makes sense... but at the same time I wonder if It can confuse people why "Save to Bookmarks" is something that is shown inside the addon interface and you can't save somewhere specific into bookmark. Basically I thought that the description of the addon should cover the actual behaviour and everyone would understand that it means. Yeah... one thing is clear. There's more I can do regarding explanations, tooltips and even improve the tutorial (if people do actually look over it, it should explain a lot) but it's hard to decide what exactly covers everyone understanding of specific feature properly.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ReDEnergy/SessionSync/issues/67#issuecomment-482113792, or mute the thread https://github.com/notifications/unsubscribe-auth/AhveCUrcCrToCPWJqcQwvpdFlrrBvuL3ks5vfzhagaJpZM4cmDb3 .

--

Best Regards, Andrew Suares