search

ReDI-School / F24-Berlin-Web-Circle

6 stars 1 forks source link

Feature/meet the host #45

Closed BajalanIman closed 6 days ago

BajalanIman commented 1 week ago

This is the "Meet your host" component.

matus-vacula commented 1 week ago

Great work putting out a pull request so quickly! 🚀 Opening a pull request even before it's fully fine-tuned to every last detail is a good practice because it helps you collect the feedback very early. I often open a PR when I just want to see if the general direction I'm going with is correct. This usually saves me time because I don't have to work on the details if I find out that need to choose a completely different solution.

I think the great potential improvement for your PR would be to start using props for the data which will be passed to the component dynamically. You can read more on props in React documentation here https://react.dev/learn/passing-props-to-a-component and if something is not clear you can always ask either by replying here in the PR to the comments or if it's more broad topic we can discuss it in the slack channel.

Also, it would be amazing if you could always post a screenshot in the PR when you're working on something visual. Keep up the good work! Excited to see more.