Open GabrielMelhem opened 1 week ago
Happy to see another amazing Pull Request! 🥳 Please check my comments and also it would be amazing if you could post a screenshot here in the PR whenever you're working on something visual.
I can see some minor issues:
we have two console.logs, one at searchbar and one at app. is this on purpose for something and i am not getting it?
the two conflicting files readme and app.jsx
styling: the labels are a bit to much at top, and on a vertical line, the labels and placeholders from input field are not matching.
I would say, we have to place the header and the searchbar components into the root, because we need both global across the pages. but may i am wrong...
the functionality looks good to me, but may i miss something
I can see some minor issues:
- we have two console.logs, one at searchbar and one at app. is this on purpose for something and i am not getting it?
- the two conflicting files readme and app.jsx
- styling: the labels are a bit to much at top, and on a vertical line, the labels and placeholders from input field are not matching.
- I would say, we have to place the header and the searchbar components into the root, because we need both global across the pages. but may i am wrong...
- the functionality looks good to me, but may i miss something
thank you Micha for the comment i checked the code again and solved all the points you mentioned.
i think now the ticket also ready to merge into the main branch
1- Implemented searchbar 2- solve the issues 3- fix the confilcts
4- Closes #38
here it is: