ReDI-School / F24-Berlin-Web-Circle

6 stars 1 forks source link

Feature/add header with logo #53

Open miklesch opened 6 days ago

miklesch commented 6 days ago

Closes #19

Task: The feature should look like: Image

The feature looks like: grafik

This feature adds a header component and its styling, with the airbnb logo, a stays and experiences buttons section in the middle and on the right side a host button and a language selector button.

The header component contains following sub-components:

Please review the feature and approve if okay.

miklesch commented 5 days ago

I downloaded the used icons as svg files and have put them into the assets folder. Is this ok or should I better implement them from package.json?

GabrielMelhem commented 4 days ago

I downloaded the used icons as svg files and have put them into the assets folder. Is this ok or should I better implement them from package.json?

Hey Micha, so my opinion is we can directly link the icons images with the orginal website images during href, i will do like this when i am working on project alone to make sure that they are available always localy and globaly.

but what you did also a good solution when whe are working on a sample project .

I also checked the code so I can see a small issue :

miklesch commented 4 days ago

Hey Gabriel, thanks for having a look on it. I checked the remote branch and the ToogleButtonStaysExperiences component is in the components folder. I will check for the styling :-)

awalmubarak commented 3 days ago

According to the Acs the header is suppose to span the entire width of the screen but what I see when I run the app doesn't span the entire width of the screen.

Screenshot 2024-09-26 at 19 29 29
messkalina commented 1 hour ago

The page doesnt render when I am opening your branch locally. There is a problem with a Footer component, but I assume this is not part of your Header component, right?

Screenshot 2024-09-30 at 14 44 46