ReFirmLabs / binwalk

Firmware Analysis Tool
MIT License
11.16k stars 1.56k forks source link

ext4 detection signature problem #495

Closed dvyurij closed 4 years ago

dvyurij commented 4 years ago

Hello, I think binwalk have wrong signature detection address in ext4 file system

Here 0x43C seems to mean minor revision level https://github.com/ReFirmLabs/binwalk/blob/5b6c4cee2572709c06f7b18af5aa77d82bce9499/src/binwalk/magic/filesystems#L536

According to ext4 disk layout page, 0x3C offset stands for s_errors. I think the correct minor revision offset is 0x3E (0x400 is zero padding offset)