Recognize S-Record and HEX firmware files with Windows style \r\n line-endings

ReFirmLabs / binwalk

Firmware Analysis Tool

MIT License

10.54k stars 1.51k forks source link

Recognize S-Record and HEX firmware files with Windows style \r\n line-endings #565

Open nightlark opened 2 years ago

nightlark commented 2 years ago

I've come across a few S-Record and Intel HEX files (probably created by Windows software) that have Windows style \r\n line terminators. As far as I can tell, the standard line-endings for these files types is whatever the OS the file was created on uses.

Adding \r? to the regex for matching these firmware file types makes so that they are recognized by binwalk.

nightlark commented 1 year ago

@devttys0 - it has been a while without hearing anything on this (or quite a few other PRs), is binwalk still being maintained, looking for new maintainers, etc?