search

ReFirmLabs / binwalk

Firmware Analysis Tool
MIT License
10.77k stars 1.54k forks source link

deps.sh prints executed statements because of set -x / Debug mode active #586

Closed Phiwatec closed 1 week ago

Phiwatec commented 2 years ago

When the script is executed it prints out all commands executed which looks pretty messy:

    + which lsb_release
    + '[' 0 -eq 0 ']'
    ++ lsb_release -i
    ++ cut -f 2
    + distro=Debian
    ++ lsb_release -r
    ++ cut -f 2
    ++ cut -c1-2
    + distro_version=11
    + REQUIRED_UTILS='wget tar python'
    + APTCMD=apt
    + APTGETCMD=apt-get
    + YUMCMD=yum
    + '[' Debian = Kali ']'
    + '[' 11 = 14 ']'
    + '[' 11 = 15 ']'

Although this is helpful for debugging it is not needed when using the script to install the dependencies. I would recommend commenting it out (and adding comment that it's useful for debugging) or removing it completely. This seems to be a relic from Release 2.3.1 where it first came up after debugging an issue with the script.

If this is wanted behavior you can close this issue :)