ReFirmLabs / binwalk

Firmware Analysis Tool
MIT License
10.38k stars 1.49k forks source link

call unrar with path extraction and without any interaction #600

Open hannob opened 2 years ago

hannob commented 2 years ago

This is a fix for #457 - binwalk can hang with rar archives.

binwalk calls unrar with e, which does not extract paths, and without -y, meaning files won't be overwritten. The tool asks the user if it shall overwrite a file, but given it's called from binwalk without interaction it just hangs.

This changes two things: