search

ReFirmLabs / binwalk

Firmware Analysis Tool
MIT License
10.75k stars 1.54k forks source link

Updated deps.sh to reflect branch rename in ubi_reader from 'master' … #636

Closed Neowizard closed 1 week ago

Neowizard commented 1 year ago

The maintainers over at UBI Reader changed their default branch name to "main" yesterday. The clone commands in deps.sh assumes there's a "master" branch which broke deps.sh, so I changed it to clone the "main" branch instead of "master"

marcellomaugeri commented 1 year ago

@Neowizard this fix cannot work since in the "main" branch there is no setup.py anymore

Neowizard commented 1 year ago

Yeah, they made yet another breaking change over at ubi_reader when they moved to Poetry...

Wouldn't it be better, at this point, if binwalk would install ubi_reader from PyPi using pip?

I worked around this issue with a sed one-liner

sed -i '/git clone --quiet --depth 1 --branch "master" https:\/\/github\.com\/jrspruitt\/ubi_reader/c\pip install ubi_reader; return' ./deps.sh