ReFirmLabs / binwalk

Firmware Analysis Tool
MIT License
10.35k stars 1.49k forks source link

Error when installing ubi_reader in deps.sh #642

Closed nhtri2003gmail closed 11 months ago

nhtri2003gmail commented 1 year ago

Hi, when I want to install with deps.sh, the following code throws error:

116: function install_ubireader
117: {
118:     git clone --quiet --depth 1 --branch "master" https://github.com/jrspruitt/ubi_reader
119:     (cd ubi_reader && $SUDO $PYTHON setup.py install)
120:     $SUDO rm -rf ubi_reader
121: }

When I try to search for that git link, it redirects me to this git repo: https://github.com/onekey-sec/ubi_reader

I see there is no brance master in that so I think the best way to install that is using python

function install_ubireader
{
    $SUDO $PYTHON -m pip install ubi_reader
}
adlra commented 1 year ago

https://github.com/ReFirmLabs/binwalk/pull/639/files

nhtri2003gmail commented 1 year ago

https://github.com/ReFirmLabs/binwalk/pull/639/files

That works for me, thanks a lot!