search

ReFirmLabs / binwalk

Firmware Analysis Tool
MIT License
10.35k stars 1.49k forks source link

Dockerfile fails to build due to ubi_reader changes #658

Open whoami-defnotme opened 9 months ago

whoami-defnotme commented 9 months ago

I received build errors while trying to build an image using the current Dockerfile in this repo.

ubi_reader now uses main as the default branch instead of master and no longer uses a setup.py file.

I was able to change this function in deps.sh to simply use the following command (recommended from ubi_reader and was able to successfully build the Docker image:

install_pip_package "ubi_reader"

I'm not sure if this is the code change you want or if you'd rather change the install_ubireader to directly install from source so I'm just raising this as an issue instead of providing this as a PR.

vincejv commented 9 months ago

thanks for this! was able to run binwalk successfully from docker, i hope the maintainers have the time to update the code