ReFirmLabs / binwalk

Firmware Analysis Tool
MIT License
10.95k stars 1.55k forks source link

Add Cargo.lock file #697

Open KSJ2000 opened 3 days ago

KSJ2000 commented 3 days ago

Please add the Cargo.lock file so that when building the nix derivation for the rust implementation of binwalk, it will not needed to define each dependency and it's hash, because the cargoHash will be used. https://nixos.org/manual/nixpkgs/stable/#rust It'd be great if you could also add a nix derivation for a fully reproducible build of binwalk, since what is from the Dockerfile for sure isn't, since the answer is no to the question: will this result in the same build inputs in half a year, or maybe 2 years. https://github.com/ReFirmLabs/binwalk/blob/d0c89d855bee7cb8e3bfe7424db2e5c59ab88ebd/Dockerfile#L6

devttys0 commented 3 days ago

Added Cargo.lock to the git repo. I like the nix idea, I'll leave this issue open until that is implemented. Thanks!