search

ReMinecraftPE / mcpe

ReMinecraftPE - A custom experience based on Minecraft PE as of 2011.
https://discord.gg/UKGhuKNmFu
Other
308 stars 47 forks source link

iOS Support #88

Closed BrentDaMage closed 6 months ago

BrentDaMage commented 8 months ago

It's enough to get a world loaded and rendering on an iPhone. Commits also include a number of general bugfixes & corrections to the codebase. 2023_11_01_04_18_IMG_0561

iProgramMC commented 8 months ago

Nice! Although just like #79 I will mark as draft until I finish the touch code. Speaking of which I really should continue working on it.

iProgramMC commented 8 months ago

Good news, I've added in the touch screen support. Please rebase and integrate my changes.

TheBrokenRail commented 8 months ago

A lot of the indentation in this PR seems messed up.

iProgramMC commented 7 months ago

BTW, on your final commit, could you add "Closes #84"?

BrentDaMage commented 7 months ago

BTW, on your final commit, could you add "Closes #84"?

Sure thing. I still need to add world saving and options.txt loading and saving. Once that's done we should be all good to go minus an intermittent RakNet assertion that seems to affect LAN broadcasting.

iProgramMC commented 7 months ago

Could you try rebasing? I see undefined references to ModelPart.

iProgramMC commented 7 months ago

Also, BTW, not sure why default8.png would require a replacement, but I've messaged you my (WIP) texture pack's font, which is complete.

BrentDaMage commented 7 months ago

Could you try rebasing? I see undefined references to ModelPart.

How? I haven't pulled any of your changes in ages.

BrentDaMage commented 7 months ago

If you check the actual branch on my fork, everything's compiling fine according to the actions. I'm not sure what GitHub's actions are doing here, but it seems like the actions for the PR are being ran on master somehow.

iProgramMC commented 7 months ago

Hmm, you're right, weird. Once we're done, I'll take a look.

iProgramMC commented 6 months ago

Any updates?

iProgramMC commented 6 months ago

FYI the merge was done on accident - I was thinking it would rebase your changes onto master and put the changes on YOUR fork. Sorry, open again please.

BrentDaMage commented 6 months ago

FYI the merge was done on accident - I was thinking it would rebase your changes onto master and put the changes on YOUR fork. Sorry, open again please.

How?

iProgramMC commented 6 months ago

I don't even know... I was trying to pull master's changes over to your branch but it did the reverse

BrentDaMage commented 6 months ago

I don't even know... I was trying to pull master's changes over to your branch but it did the reverse

No. As in how do I reopen the pull request without making a completely new one?

iProgramMC commented 6 months ago

By "open again", I mean open a new PR again with the platform-ios branch. I believe you can do that, if not, just clone the branch. I don't actually believe you can reopen a PR once it's been merged - I would have done that already by now if that is the case.

On Mon, Jan 1, 2024, 10:29 Brent @.***> wrote:

I don't even know... I was trying to pull master's changes over to your branch but it did the reverse

No. As in how do I reopen the pull request without making a completely new one?

— Reply to this email directly, view it on GitHub https://github.com/ReMinecraftPE/mcpe/pull/88#issuecomment-1873222985, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEHFR5XCSHF7EBGMSB76GM3YMJXXXAVCNFSM6AAAAAA6Y73NB6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZTGIZDEOJYGU . You are receiving this because you modified the open/close state.Message ID: @.***>