ReMon-MVEE / ReMon

Other
27 stars 10 forks source link

some fixes needed on my machine #1

Closed dmwit closed 7 years ago

dmwit commented 7 years ago

Hey, on my machine (Ubuntu 16.04) I needed a few fixes for this to build. Not entirely sure why -- I could swear just last week I got this building without modifications on a 16.04 VM.

The WTERMSIG call patch especially deserves an extra eyeball. I think that by the time we reach this codepoint the guy who constructed the status should already have called WTERMSIG for us already, but somebody who's more familiar with the guts should verify that this is indeed the intended behavior. (Also it seems strange to me that this ever compiled, which makes me extra confused about whether this is the right fix or not.)

stijn-volckaert commented 7 years ago

Hi Daniel,

this was indeed a bug. I probably introduced it in a recent refactoring spree. Keep in mind that ReMon might not work 100% as expected on Ubuntu 16.04 because we forcibly load old versions of glibc/libstdc++/etc into the variants' address spaces. I will try to push updated binaries soonish.

Thanks, Stijn