search

RePod / psdle

Improving everyone's favorite online download list, one loop at a time.
https://repod.github.io/psdle
MIT License
194 stars 14 forks source link

Disabling "Catalog" gives 0 results, and item counter bug #12

Closed EvilCanasta closed 9 years ago

EvilCanasta commented 9 years ago

I think this problem appeared with one of the latest revisions of this plugin.

Before that, by disabling "Catalog", the resulting list took a lot less time to be created, but it's probably less accurate (as implied by the description), now you don't even get basic filters anymore.

Also, i've noticed something strange: when you start creating the list (with all options enabled) the item counter starts at 240-something, then it DECREASES, and increases again like nothing ever happened. You still get the full list after that, though.

ps: will there ever be a way to completely disable the list window after you stop using it? I know you can simply reload the page, but the SEN one is not exactly one of the fastest sites in the world. I've tried disabling all filters but it still covers the search bar and the account options.

Oh and another thing: did you remove the PS2 filter for PS2 Classics? I don't have many PS2 titles, but they're listed as PS3 now. I guess it's because they're only for PS3?

RePod commented 9 years ago

Disabling "Catalog" gives 0 results

I am unable to replicate this behavior and probably will not be able to since this seems to be a problem with the Entitlements.

What happens if you try after logging out and back in or visiting the Download List first?

now you don't even get basic filters anymore.

Disabling the Catalog disables filters (Game, Demo, etc.) which are determined from the Catalog. No Catalog, no filters.

then it DECREASES, and increases again like nothing ever happened.

This is an issue due to a recent Catalog change I made. Nothing's broken, PSDLE just can't count.

Personally, I find it hilarious. It's definitely not the first time a problem like this has popped up.

ps: will there ever be a way to completely disable the list window after you stop using it?

It's available internally as repod.psdle.debug.die() but not on the interface. Eventually I'll get around to doing this.

did you remove the PS2 filter for PS2 Classics?

No, and the ones I have are still working fine. However, I've recently made a change for scalable system filters to show only what is detected (hide PS1 if no PS1 games) which means there might be a problem with the detection. Please link them or name them and their store region so I can look into it.

EvilCanasta commented 9 years ago

Thanks for the reply.

RePod commented 9 years ago

I pushed an update (userscript 2.033 and direct equivalent), please try either of those and see if the problem persists before I continue.

Also for clarification:

If you're not using the userscript, after the list would be generated please paste the following in your browser console (Firefox: Ctrl+Shift+K, Chrome: Ctrl+Shift+J) and give the results: console.log(repod.psdle.gamelist.length, repod.psdle.gamelist_cur.length, gEntitlementManager.getAllEntitlements().length)

EvilCanasta commented 9 years ago

I visit the site from PC using the latest version of Firefox. I didn't notice anything different with the new update except for Stuntman Ignition which is recognized as a PS2 title once again.

EDIT: i tried pasting that but i only get "undefined" and three numbers (two are the number of items on my download list, the third is "2797")

RePod commented 9 years ago

Please do the following, from the webstore:

The link contains a minor change to the code which disables a recent Catalog change. If this fixes the issue, I will have located the source and will begin working on it.

EvilCanasta commented 9 years ago

That's all i'm getting:

"PSDLE | Ready." "PSDLE | Init." POST https://store.sonyentertainmentnetwork.com/event/batch [HTTP/1.1 200 OK 10563ms] POST https://store.sonyentertainmentnetwork.com/event/batch [HTTP/1.1 200 OK 1193ms] POST https://store.sonyentertainmentnetwork.com/event/batch "An error occured sending an event to Kamaji Events API! error: timeout : timeout"

RePod commented 9 years ago

Did you attempt using PSDLE (with that link's contents) as normal? Use only that link to start PSDLE. No userscript, bookmarklet, or any other method.

Seems to be working for me on the it-it webstore.

EvilCanasta commented 9 years ago

Sorry, i don't get it... what do you mean with "normal"? I normally use it through Greasemonkey, which was already disabled. I used the "Direct" version from your site, and pasted the stuff from a couple of posts ago in the console, and it gives nothing, i pasted the content of that other link, and it gives nothing. I normally don't do things like that, sorry for any inconvenience.

RePod commented 9 years ago

By just using the link provided above you should be able to access PSDLE after posting the contents into the console and submitting it. If you are unable to, that's another issue that needs to be addressed.

EvilCanasta commented 9 years ago

Oh, ok, sorry, now i understand what to do, will try again.

The counter seems to be working properly with that method. It starts from zero.

EDIT: both the PS2 games mentioned are properly listed as PS2 like before. Also, that seems to have fixed another side issue with two of my PS1 games (previously listed as PS3... that was already reported, but why some PS1 titles are listed under "PSP" or "PS3" instead of PS1?)

Now, trying to create a list without Catalog enabled still gives 0 results but not a single filter (i repeat, it should be able to do so, it just doesn't give filters like Themes, Demos etc. just the "basic" ones for the systems), there's a "small" difference though, it gives "0 / ####" results (my current total of items) even if i don't access the Download List (normally it shows "0 / 0" with the current version of PSDLE)

RePod commented 9 years ago

Before you proceed below, using the previous link please run the following in console when the list would be displayed:

repod.psdle.sys_cache

Please also try this link (of an older version).

This older version has hard coded systems to display, which may or may not be the issue.

EvilCanasta commented 9 years ago

I don't understand what you mean with "when the list would be displayed"? I ran that and it displayed a single line of code. Anyway, the plugin has become super sloooow lately...

ps do you know anything regarding the other stuff mentioned in my previous post?

RePod commented 9 years ago

"when the list would be displayed"

When it shows "0 / ####", submit repod.psdle.sys_cache into the console. It should return an object of detected systems which PSDLE uses to generate the portion of the interface which lets you select the systems. If this is empty, this is most likely the problem.

As for mislabeled systems while I know a bit about the Catalog, I don't know everything. A lot of the information from it I use to figure these things out overlaps and may cause false positives. For instance, some of the Final Fantasy PSP ports/remakes, despite being PSP games are also considered "PS1 Classics".

EvilCanasta commented 9 years ago

Well i'm getting this:

Object { vita: "PS Vita", ps4: "PS4", ps3: "PS3", psp: "PSP", ps1: "PS1", ps2: "PS2" }

The "older version" gives me "#### / ####" items like before, when i don't select Catalog (and filters for PS3/PS4/PSP/Vita, the PS1/PS2 games listed under their respective categories go under PS3 because i didn't select Catalog)

Do you know why using the plugin has become more resource demanding and a lot slower than before? Is that because of changes on PSN or the latest versions of the plugin?

RePod commented 9 years ago

Do you know why using the plugin has become more resource demanding and a lot slower than before? Is that because of changes on PSN or the latest versions of the plugin?

As far as PSDLE is concerned, it's not doing much more than it has before (except for storing more information from the Catalog, which you're not using). I have no information about the performance of the webstore itself.

This time I have two steps that need to be done:

EvilCanasta commented 9 years ago

It gives me 404 error.

RePod commented 9 years ago

Whoops, updated.

EvilCanasta commented 9 years ago

The list is created after i use that version, what now?

EDIT: still gives 0 out of my total results with Catalog disabled, using that command from a couple of posts ago gives "Object { }", moving between Queue and List does not fix it.

RePod commented 9 years ago

I went ahead and made an Italian PSN account to speed up the process and make your life easier before throwing a million more files and commands at you and found the cause! Also fixed it, or something.

Before I push it to live, please verify this version which I just pushed before making this post.

To expand on your question about PSDLE, or the store, getting slower I will say PSDLE is doing more loops now to "smartly" generate information. Before, the systems and category filters were hard-coded but are now dynamically generated every time instead. On their own they're not too big of a burden but when they are all processed at once there may be a small hiccup in performance (like when the table is first generated).

EvilCanasta commented 9 years ago

Well that one creates a list without Catalog enabled, but the "decreasing counter" bug has returned :D

RePod commented 9 years ago

That's another issue entirely, it's been commented out this entire time.

I'll take this as meaning it's fixed. If you have any other issues (aside from PSDLE not knowing how to count!), feel free to make a new issue.

EvilCanasta commented 9 years ago

It's not really fixed, but i've opened a new issue.