RePod / psdle

Improving everyone's favorite online download list, one loop at a time.
https://repod.github.io/psdle
MIT License
193 stars 14 forks source link

Userscript only scanning 1 page then getting stuck #5

Closed oldmario closed 9 years ago

oldmario commented 9 years ago

it zooms down the list like it use to but gets stuck after it finishes on the first page and goes back to the top of the download list

RePod commented 9 years ago

Is this on the desktop or mobile version of the online store? Only the desktop version scrolls the page. What's the store's language/region? (e.g. en-us) What browser is this happening in? Does this only happen with the userscript? Have you tried the bookmarklet or direct method? Are you using the latest version of the userscript (1.049)? (Viewable in your Monkey variant's dashboard/script list)

During execution open the browser console (Firefox: Ctrl+Shift+K, Chrome: Ctrl+Shift+J), do you see anything in red (error) or yellow (warning)? (Ensure all logging options are enabled) If so, post those here.

Thanks.

oldmario commented 9 years ago

i'm using the latest version of firefox on desktop, language is en-us when i ran the script with the console opened this appears

"PSDLE | Ready." "PSDLE | Init."

then it shoots down the first page like it should an this pops up

TypeError: t.find(...).text(...).match(...) is null

RePod commented 9 years ago

Disable the userscript, open the browser console, input the following, and press Enter:

$.getScript("https://gist.githubusercontent.com/RePod/84fabd024fd3b569ac3a/raw/c6d7fdae22f7dce59b00317899e82b797fef2aff/PSDLE");

This is a slightly modified version that attempts to parse the "size" of an item differently (also with an extra logging command to see where it's stopping at, if it still does).

However I believe the cause may be due to incorrectly parsing the "size" of the item, are there any awkwardly formatted or missing values on the page?

Thanks.

oldmario commented 9 years ago

i entered that and this appeared

Object { readyState: 1, getResponseHeader: .ajax/C.getResponseHeader(), getAllResponseHeaders: .ajax/C.getAllResponseHeaders(), setRequestHeader: .ajax/C.setRequestHeader(), overrideMimeType: .ajax/C.overrideMimeType(), statusCode: .ajax/C.statusCode(), abort: .ajax/C.abort(), state: .Deferred/r.state(), always: .Deferred/r.always(), then: .Deferred/r.then(), 8 more… }

nothing happens after this

if it's any help some of the sizes are reported as "N/A" which is just PS4 dlc for Resogun and Driveclub

RePod commented 9 years ago

Pushed a very crude fix, but a fix nonetheless. Try updating to 1.052 (force update in Greasemonkey) and see if this resolves it.

Until I have a better solution it will set entries with "N/A" (or just not matching to begin with) to 0KB.

oldmario commented 9 years ago

that fixed it thanks

RePod commented 9 years ago

No problem, it's what I do!