search

RePod / psdle

Improving everyone's favorite online download list, one loop at a time.
https://repod.github.io/psdle
MIT License
193 stars 14 forks source link

CSV data is not well-formed when content contains quotes #58

Closed windsurfer1122 closed 6 years ago

windsurfer1122 commented 6 years ago

The CSV data is incorrect if a field contains quotes: PS4,,,"Sackleinen"-Düfte für Sackboy,,,EP9000-CUSA00762_00-LBPDLCORIGCO0014,,,,,,,,,,,,,['PS4'],EP9000-BCES00141_00-LBPDLCORIGCO0014,

According to RFC4180 if a field contains quotes the whole field must be enclosed in quotes and the quotes of the content muss be doubled: PS4,,,"""Sackleinen""-Düfte für Sackboy",,,EP9000-CUSA00762_00-LBPDLCORIGCO0014,,,,,,,,,,,,,['PS4'],EP9000-BCES00141_00-LBPDLCORIGCO0014,

Quotes around the field must also be used if the content contains the field separator (comma or semicolon) and/or CRLF, CR, LF.

RePod commented 6 years ago

Please run this version of PSDLE and tell me if you receive the expected output. Just copy and paste the contents of the URL into console on the webstore (FF: Ctrl+Shift+K, Chrome: Ctrl+Shift+J) and run it.

PSDLE has always removed all linefeeds in its output. Escaping them would also be possible but to my knowledge only one field actually uses it and that's the item "description" if Catalog is enabled.

windsurfer1122 commented 6 years ago

This looks perfect. Would you also consider to include the solution for the "empty" property suggestion #46? Thanks.