search

RePod / psdle

Improving everyone's favorite online download list, one loop at a time.
https://repod.github.io/psdle
MIT License
193 stars 14 forks source link

3.3.7: "Import"ing an unknown property for "Export View" disables Export #62

Closed windsurfer1122 closed 5 years ago

windsurfer1122 commented 5 years ago

Browser: Chrome

Method: Extension

Online store version and language: Desktop

PSDLE version: 3.3.7

Is Catalog enabled: Yes

Problem: When "Import"ing an unknown property for "Export View", then PSDLE just returns to the list and "Export View" cannot be clicked anymore.

How to replicate: Click "Export View" Click "Import" Enter [["PSDLE Category","category"]] (note that the existing property "category" is on the wrong side, and that a property "PSDLE Category" does not exist) Click "Ok"

Other notes: First expected an error message like "Properties "PSDLE Category" do not exist and are skipped". Second that unknown properties are skipped and "Export View" keeps useable.

RePod commented 5 years ago

I have the fix in place but without adding a new line to the translation I don't have a way to properly convey the invalid props.

Maybe it's not important and silently omit them? If a user is importing a custom the problem lies in who/where they got it from and they may not care enough to fix the line themselves.

RePod commented 5 years ago

Currently it operates silently like this: 2019-01-04_15-36-42 Feedback about the importance of the errors is welcomed. Right now the only idea I'm confident with involves adding a new line to the translations, but I'm not against it or any alternatives.

windsurfer1122 commented 5 years ago

An error message would help to recognize the problem immediately, and should reduce false-positive issues. I got my property error from myself due to a copy&paste plus regex rename mistake inside my own notes :(

Does PSDLE fallback to English if the translation is missing? If so, then I would definitely add the error message. Otherwise I would also be fine without an error message.

Thanks for reacting so fast.

RePod commented 5 years ago

The original fix described above (removing keys) has been pushed to live 3.3.8 along with other changes. Though still not presenting a dialog about removed keys they are currently logged into the browser console.

windsurfer1122 commented 5 years ago

Shall we close this issue?